Closes #17; Better Domain Filtering #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tjmehta - Please review. |
|
it looks like your branch has duplicates of commits that are now on master... maybe rebase? |
|
Just needed to merge them in. Sorry about that. |
| return names.filter(function (name) { | ||
| return ~name.indexOf(process.env.DOMAIN_FILTER); | ||
| return name.match(regexFilter); |
There was a problem hiding this comment.
it looks like you're filtering and allowing anything on a domain (good), but then looking for 0-infinite whitespace after before the end of the line? why not just trim?
| ]; | ||
| query.resolve('127.0.0.1', names, function (err, records) { | ||
| if (err) { return done(err); } | ||
| expect(records).to.be.null(); |
There was a problem hiding this comment.
to help prevent this, add -a code to the lab command - it'll throw errors if not all the expect(...)s are resolved
|
if you want to update the |
rsandor
added a commit
that referenced
this pull request
Apr 24, 2015
Closes #17; Better Domain Filtering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a regex to ensure that the domain filter appears at the end of the domain instead of anywhere.