-
Notifications
You must be signed in to change notification settings - Fork 0
Add agreeable egret #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agreeable egret #597
Conversation
ansible/agreeable-egret.yml
Outdated
@@ -0,0 +1,10 @@ | |||
--- | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove space
ansible/agreeable-egret.yml
Outdated
- role: notify | ||
tags: [ notify ] | ||
- { role: builder, tags: [build] } | ||
- { role: container_kill_start } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
container_start
ansible/delta-hosts/variables
Outdated
@@ -148,6 +148,7 @@ datadog_mongodb_pwd=sqa3WBgkCgZsFZuex0kBNahZ | |||
datadog_mongodb_user=datadog | |||
datadog_tags=env:delta | |||
domain=runnable.io | |||
agreeable_egret_hello_runnable_github_token=b6130cbbd1be797d83b3d419ba60176e7b3f07d2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove use api_hello_runnable_github_token
ansible/gamma-hosts/variables
Outdated
@@ -130,6 +130,7 @@ datadog_mongodb_pwd=sqa3WBgkCgZsFZuex0kBNahZ | |||
datadog_mongodb_user=datadog | |||
datadog_tags=env:gamma | |||
domain=runnable-gamma.com | |||
agreeable_egret_hello_runnable_github_token=b6130cbbd1be797d83b3d419ba60176e7b3f07d2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove use api_hello_runnable_github_token
@@ -0,0 +1,18 @@ | |||
name: "arithmancy" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change to repo name
|
||
# container settings | ||
container_envs: > | ||
-e HELLO_RUNNABLE_GITHUB_TOKEN={{ agreeable_egret_hello_runnable_github_token }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api_hello_runnable_github_token
container_run_opts: > | ||
-h {{ name }} | ||
-d | ||
-v /opt/ssl/docker/{{ name }}:/etc/ssl/docker:ro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
1adcc1a
to
7c9f0fd
Compare
NICE!, test by deploying to gamma |
a6bfd7c
to
de54f3a
Compare
ansible/agreeable-egret.yml
Outdated
roles: | ||
- role: notify | ||
tags: [ notify ] | ||
- { role: builder, tags: [build] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spacing. -
should be under the t
in tags
ansible/delta-hosts/hosts
Outdated
@@ -149,6 +152,7 @@ dock | |||
docker-listener | |||
docks | |||
drake | |||
agreeable-egret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... might need to brush up on your alphabet :P
ansible/delta-hosts/variables
Outdated
@@ -1,3 +1,8 @@ | |||
[agreeable-egret:vars] | |||
agreeable_egret_port=65520 | |||
agreeable_egret_api_url=https://api.runnable.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this, change ENV to use {{ api_url }}
you can find it defined here
devops-scripts/ansible/group_vars/all.yml
Line 60 in cc87ba3
api_url: https://{{ api_hostname }} |
ansible/delta-hosts/variables
Outdated
[agreeable-egret:vars] | ||
agreeable_egret_port=65520 | ||
agreeable_egret_api_url=https://api.runnable.io | ||
egret_postgres_connect_string=postgres://egret:wwHQ5B4RfY9iKS3m@delta-big-poppa.cnksgdqarobf.us-west-2.rds.amazonaws.com/egret |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: lets clean this up like big papa does.
list components like so:
big_poppa_pg_host=delta-big-poppa.cnksgdqarobf.us-west-2.rds.amazonaws.com |
add to ENV like so:
-e POSTGRES_CONNECT_STRING=postgres://{{ big_poppa_pg_user }}:{{ big_poppa_pg_pass }}@{{ big_poppa_pg_host }}/{{ big_poppa_pg_database }} |
ansible/gamma-hosts/variables
Outdated
@@ -1,3 +1,8 @@ | |||
[agreeable-egret:vars] | |||
agreeable_egret_port=65520 | |||
agreeable_egret_api_url=https://api.runnable.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above. Also scary that your talking to io for gamma :P
-e RUNNABLE_API_URL={{ agreeable_egret_api_url }} | ||
-e PORT={{ hosted_ports[0] }} | ||
-e RUNNABLE_USER_CONTENT_DOMAIN={{ user_content_domain }} | ||
-e POSTGRES_CONNECT_STRING={{ egret_postgres_connect_string }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do something like this instead:
-e POSTGRES_CONNECT_STRING=postgres://{{ big_poppa_pg_user }}:{{ big_poppa_pg_pass }}@{{ big_poppa_pg_host }}/{{ big_poppa_pg_database }} |
it makes it easier to read.
container_envs: > | ||
-e HELLO_RUNNABLE_GITHUB_TOKEN={{ api_hello_runnable_github_token }} | ||
-e NODE_ENV={{ node_env }} | ||
-e RUNNABLE_API_URL={{ agreeable_egret_api_url }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change this to {{ api_url }}
c171644
to
c6f9fdd
Compare
-e RUNNABLE_API_URL={{ api_url }} | ||
-e PORT={{ hosted_ports[0] }} | ||
-e RUNNABLE_USER_CONTENT_DOMAIN={{ user_content_domain }} | ||
-e POSTGRES_CONNECT_STRING=-postgres://{{ egret_pg_user }}:{{ egret_pg_pass }}@{{ egret_pg_host }}/{{ egret_pg_database }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that -
supposed to be there?
test deploy to prod and gamma to make sure this works then merge :) |
e83f2db
to
28a5cf1
Compare
28a5cf1
to
76e6749
Compare
This PR will allow us to deploy agreeable-egret to app-services.