Skip to content

Add agreeable egret #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 6, 2017
Merged

Add agreeable egret #597

merged 12 commits into from
Feb 6, 2017

Conversation

henrymollman
Copy link

This PR will allow us to deploy agreeable-egret to app-services.

@@ -0,0 +1,10 @@
---

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space

- role: notify
tags: [ notify ]
- { role: builder, tags: [build] }
- { role: container_kill_start }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

container_start

@@ -148,6 +148,7 @@ datadog_mongodb_pwd=sqa3WBgkCgZsFZuex0kBNahZ
datadog_mongodb_user=datadog
datadog_tags=env:delta
domain=runnable.io
agreeable_egret_hello_runnable_github_token=b6130cbbd1be797d83b3d419ba60176e7b3f07d2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove use api_hello_runnable_github_token

@@ -130,6 +130,7 @@ datadog_mongodb_pwd=sqa3WBgkCgZsFZuex0kBNahZ
datadog_mongodb_user=datadog
datadog_tags=env:gamma
domain=runnable-gamma.com
agreeable_egret_hello_runnable_github_token=b6130cbbd1be797d83b3d419ba60176e7b3f07d2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove use api_hello_runnable_github_token

@@ -0,0 +1,18 @@
name: "arithmancy"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to repo name


# container settings
container_envs: >
-e HELLO_RUNNABLE_GITHUB_TOKEN={{ agreeable_egret_hello_runnable_github_token }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api_hello_runnable_github_token

container_run_opts: >
-h {{ name }}
-d
-v /opt/ssl/docker/{{ name }}:/etc/ssl/docker:ro

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@anandkumarpatel
Copy link

NICE!, test by deploying to gamma

roles:
- role: notify
tags: [ notify ]
- { role: builder, tags: [build] }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing. - should be under the t in tags

@@ -149,6 +152,7 @@ dock
docker-listener
docks
drake
agreeable-egret

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... might need to brush up on your alphabet :P

@@ -1,3 +1,8 @@
[agreeable-egret:vars]
agreeable_egret_port=65520
agreeable_egret_api_url=https://api.runnable.io

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this, change ENV to use {{ api_url }} you can find it defined here

api_url: https://{{ api_hostname }}

[agreeable-egret:vars]
agreeable_egret_port=65520
agreeable_egret_api_url=https://api.runnable.io
egret_postgres_connect_string=postgres://egret:wwHQ5B4RfY9iKS3m@delta-big-poppa.cnksgdqarobf.us-west-2.rds.amazonaws.com/egret

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: lets clean this up like big papa does.
list components like so:

big_poppa_pg_host=delta-big-poppa.cnksgdqarobf.us-west-2.rds.amazonaws.com

add to ENV like so:

-e POSTGRES_CONNECT_STRING=postgres://{{ big_poppa_pg_user }}:{{ big_poppa_pg_pass }}@{{ big_poppa_pg_host }}/{{ big_poppa_pg_database }}

@@ -1,3 +1,8 @@
[agreeable-egret:vars]
agreeable_egret_port=65520
agreeable_egret_api_url=https://api.runnable.io

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above. Also scary that your talking to io for gamma :P

-e RUNNABLE_API_URL={{ agreeable_egret_api_url }}
-e PORT={{ hosted_ports[0] }}
-e RUNNABLE_USER_CONTENT_DOMAIN={{ user_content_domain }}
-e POSTGRES_CONNECT_STRING={{ egret_postgres_connect_string }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do something like this instead:

-e POSTGRES_CONNECT_STRING=postgres://{{ big_poppa_pg_user }}:{{ big_poppa_pg_pass }}@{{ big_poppa_pg_host }}/{{ big_poppa_pg_database }}

it makes it easier to read.

container_envs: >
-e HELLO_RUNNABLE_GITHUB_TOKEN={{ api_hello_runnable_github_token }}
-e NODE_ENV={{ node_env }}
-e RUNNABLE_API_URL={{ agreeable_egret_api_url }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this to {{ api_url }}

-e RUNNABLE_API_URL={{ api_url }}
-e PORT={{ hosted_ports[0] }}
-e RUNNABLE_USER_CONTENT_DOMAIN={{ user_content_domain }}
-e POSTGRES_CONNECT_STRING=-postgres://{{ egret_pg_user }}:{{ egret_pg_pass }}@{{ egret_pg_host }}/{{ egret_pg_database }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that - supposed to be there?

@anandkumarpatel
Copy link

test deploy to prod and gamma to make sure this works then merge :)

@henrymollman henrymollman merged commit 73bab51 into master Feb 6, 2017
@henrymollman henrymollman deleted the add-agreeable-egret branch February 6, 2017 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants