Add bucket region for web #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Myztiq
reviewed
Mar 1, 2017
ansible/.npmrc
Outdated
| @@ -0,0 +1 @@ | |||
| //registry.npmjs.org/:_authToken=${NPM_TOKEN} | |||
thejsj
force-pushed
the
add-aws-region-to-fe
branch
from
e4e09e2 to
e6450f4
Compare
podviaznikov
approved these changes
Mar 1, 2017
anandkumarpatel
approved these changes
Mar 1, 2017
| @@ -14,6 +14,7 @@ dockerfile_enviroment: [ | |||
| "MIXPANEL_PROXY_URL {{ mixpanel_proxy_url }}", | |||
| "AWS_ACCESS_KEY {{ aws_access_key }}", | |||
| "AWS_BUCKET app.{{ domain }}", | |||
| "AWS_REGION {{ web_aws_bucket_region | default('us-standard') }}", | |||
There was a problem hiding this comment.
That's the default region and what we use for gamma.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
AWS_REGIONENV to webus-west-2)Deployment (post-merge)