remove redis tls #620
Merged
remove redis tls #620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejsj
approved these changes
Mar 23, 2017
There was a problem hiding this comment.
LGTM
FYI. We're still using tls for mongo. If we get rid of that I think we'll be able to get rid of local vault.
$ Ag 'tls_service: mongo'
api-core.yml
28: tls_service: mongodb
roles/khronos/meta/main.yml
3:- { role: tls-client-cert, tls_service: mongodb}
socket-server.yml
23: - { role: tls-client, tls_service: mongodb, tags: [ tls ] }
workers.yml
21: - { role: tls-client, tls_service: mongodb, tags: [ tls ] }
| @@ -301,30 +301,6 @@ | |||
| from_port: "{{ sshd_port }}" | |||
There was a problem hiding this comment.
Do we even use this file for anything?
There was a problem hiding this comment.
something chris made, not sure how it works, not worth investigating right now
There was a problem hiding this comment.
Definitely outside the scope of this PR, but we only use the ec2 role here, which I don't think gets used anywhere.
$ Ag 'role: ec2'
sg_configure.yml
8: - { role: ec2/sg_configure }
Death to sg_configure.yml.
Death to local vault.
Death to Docker Swarm.
thejsj
added a commit
that referenced
this pull request
Mar 28, 2017
…e-shared-single-host-main-ami * 'master' of github.com:CodeNow/devops-scripts: Sorted Updated vars for deploy add clio to worker and socket (#622) Remove khronos mongo certs (#621) remove redis tls (#620) split out delta-app to 2 boxes. remove unused configs (#619) Add aws host for API Remove mongo certs to run pheidi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.