-
Notifications
You must be signed in to change notification settings - Fork 0
Added keymaker configurations. #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ansible/group_vars/all.yml
Outdated
@@ -145,6 +145,13 @@ github_varnish_port: 80 | |||
# kartographer | |||
kartographer_rollbar_token: a7f85fda20bd4b9fb7b1197fc04d3c89 | |||
|
|||
# keymaker | |||
keymaker_pg_database: keymaker | |||
keymaker_port: 7788 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this conflict with BigPoppa?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, since it's in kubernetes, the port doesn't matter anymore! Woooo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we at least change it to avoid conflicts for local dev? For example, when port forwarding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have this in .env of keymaster: PORT=3008
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
value: "{{ keymaker_pg_pass }}" | ||
- name: PGHOST | ||
value: "{{ pg_host }}" | ||
- name: PGPORT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need this and the above PG*? you have the whole string below?
- group_vars/alpha-keymaker-base.yml | ||
- group_vars/alpha-keymaker-worker.yml | ||
roles: | ||
- role: builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove builder here, no need to build 2 times :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly, untrue, builder pushes the image to the remote and it's a different name, keymaker-worker vs keymaker-http
Added keymaker configurations