Skip to content

Added keymaker configurations. #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 18, 2017
Merged

Added keymaker configurations. #666

merged 11 commits into from
May 18, 2017

Conversation

Myztiq
Copy link

@Myztiq Myztiq commented May 16, 2017

Added keymaker configurations

Copy link
Member

@tosih tosih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -145,6 +145,13 @@ github_varnish_port: 80
# kartographer
kartographer_rollbar_token: a7f85fda20bd4b9fb7b1197fc04d3c89

# keymaker
keymaker_pg_database: keymaker
keymaker_port: 7788
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this conflict with BigPoppa?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, since it's in kubernetes, the port doesn't matter anymore! Woooo

Copy link
Member

@tosih tosih May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we at least change it to avoid conflicts for local dev? For example, when port forwarding.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have this in .env of keymaster: PORT=3008

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

value: "{{ keymaker_pg_pass }}"
- name: PGHOST
value: "{{ pg_host }}"
- name: PGPORT

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need this and the above PG*? you have the whole string below?

- group_vars/alpha-keymaker-base.yml
- group_vars/alpha-keymaker-worker.yml
roles:
- role: builder

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove builder here, no need to build 2 times :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, untrue, builder pushes the image to the remote and it's a different name, keymaker-worker vs keymaker-http

@Myztiq Myztiq merged commit 1862b6c into master May 18, 2017
@Myztiq Myztiq deleted the SAN-6252-keymaker branch May 18, 2017 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants