Fix tagging of image builder #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
podviaznikov
approved these changes
May 17, 2017
|
|
…ripts into fix-image-builder-push * 'fix-image-builder-push' of github.com:CodeNow/devops-scripts: update node version to the tested one
anandkumarpatel
requested changes
May 18, 2017
| repo: git@github.com:CodeNow/{{ name }}.git | ||
| node_version: "4.2.2" | ||
| npm_version: "2.15.11" | ||
| use_default_dockerfile: true |
|
|
||
| inject_ca: false | ||
| repo: git@github.com:CodeNow/{{ name }}.git | ||
| node_version: "4.2.2" |
There was a problem hiding this comment.
these are not needed if you are building from dockerfile in repo
| image_builder_docker_namespace: "{{ registry_host }}/runnable/image-builder" | ||
| app_repo: git@github.com:CodeNow/{{ app_name }}.git | ||
|
|
||
| inject_ca: false |
There was a problem hiding this comment.
not needed if dockerfile in repo
|
tested on gamma |
anandkumarpatel
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should treat our k8 files as compiled files, since we don't actually (http://blog.andrewray.me/dealing-with-compiled-files-in-git/). We should probably wait some time until we actually have more confidence in our compilation.
What this PR does
Deployment (post-merge)