Add key generators #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyoubendoing
commented
Apr 20, 2015
whatyoubendoing
commented
- Add the ability to generate keys from a “key generator”
- Include the default SHA1 and a Rails-like key generators
- Add docs & tests
added 4 commits
April 20, 2015 12:03
Update travis
Rename BaseDriver to the more implicit PDODriver. Remove Str class from being able to be passed in. Str generally won’t change.
- Add the ability to generate keys from a “key generator” - Include the default SHA1 and a Rails-like key generators - Add docs & tests
| /** | ||
| * Generates a key for a given value using the SHA1 hash. | ||
| */ | ||
| class SHA1KeyGenerator implements KeyGeneratorInterface |
There was a problem hiding this comment.
Should be named Sha1KeyGenerator per PSR, and because Crc32KeyGenerator is not named CRC32KeyGenerator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.