Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the missing make:filament-action command #43

Merged

Conversation

johntrickett86
Copy link
Contributor

I'm a big fan of action classes in general, I particularly love how you extracted Filament Actions.

This PR adds the missing php artisan make:filament-action command, allowing users to generate Filament action classes from the terminal.

@CodeWithDennis
Copy link
Owner

Hey @johntrickett86! I really like this command. Could we enhance it to allow us to select the type of action being performed? FilamentPHP supports table, form, and infolist actions.

@johntrickett86
Copy link
Contributor Author

@CodeWithDennis Yes absolutely. Let me make the change.

@CodeWithDennis
Copy link
Owner

CodeWithDennis commented Nov 1, 2024

@CodeWithDennis Yes absolutely. Let me make the change.

Maybe we can also separate this in directories just like FilamentPHP code base does?

@johntrickett86
Copy link
Contributor Author

@CodeWithDennis Yes absolutely. Let me make the change.

Maybe we can also separate this in directories just like FilamentPHP code base does?

On it!!

@johntrickett86
Copy link
Contributor Author

johntrickett86 commented Nov 1, 2024

@CodeWithDennis Okay I've added support for all of the action types and saving them in directories based on type. Let me know what you think. I've started using this in a project I'm working on and it's really helpful - turns out I was repeating myself a lot!!

@CodeWithDennis
Copy link
Owner

@CodeWithDennis Okay I've added support for all of the action types and saving them in directories based on type. Let me know what you think. I've started using this in a project I'm working on and it's really helpful - turns out I was repeating myself a lot!!

Nice work, left a couple of points.

@johntrickett86
Copy link
Contributor Author

@CodeWithDennis Thanks for the feedback. I've applied these changes 👍

@CodeWithDennis
Copy link
Owner

Made some changes @johntrickett86 let me know if you agree.

@johntrickett86
Copy link
Contributor Author

Made some changes @johntrickett86 let me know if you agree.

@CodeWithDennis All looks good to me.

@johntrickett86
Copy link
Contributor Author

@CodeWithDennis Maybe an update to the readme?

@CodeWithDennis CodeWithDennis merged commit 341080c into CodeWithDennis:main Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants