-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the missing make:filament-action command #43
Added the missing make:filament-action command #43
Conversation
Allows users to create new action classes using the terminal
Hey @johntrickett86! I really like this command. Could we enhance it to allow us to select the type of action being performed? FilamentPHP supports table, form, and infolist actions. |
@CodeWithDennis Yes absolutely. Let me make the change. |
Maybe we can also separate this in directories just like FilamentPHP code base does? |
On it!! |
@CodeWithDennis Okay I've added support for all of the action types and saving them in directories based on type. Let me know what you think. I've started using this in a project I'm working on and it's really helpful - turns out I was repeating myself a lot!! |
Nice work, left a couple of points. |
@CodeWithDennis Thanks for the feedback. I've applied these changes 👍 |
Made some changes @johntrickett86 let me know if you agree. |
@CodeWithDennis All looks good to me. |
@CodeWithDennis Maybe an update to the readme? |
I'm a big fan of action classes in general, I particularly love how you extracted Filament Actions.
This PR adds the missing
php artisan make:filament-action
command, allowing users to generate Filament action classes from the terminal.