london-10/iryna-lypnyk/completed-mandatory&extra-exercises #522

IrynaLypnyk · 2023-02-21T22:57:38Z

No description provided.

Schboostie

Hi Iryna, I really liked the way you tackled alot of the problems. I hope you found my comments useful🌟

Schboostie · 2023-02-21T23:43:05Z

mandatory/1-syntax-errors.js

-function introduceMe(name, age)
-  return `Hello, my {name}` is "and I am $age years old`;
+function introduceMe(name, age) {
+  return `Hello, my name is ${name} and I am ${age} years old`;


Good use of back tick when adding variables to a string.

Schboostie · 2023-02-21T23:47:22Z

mandatory/3-function-output.js

@@ -1,16 +1,20 @@
 // Add comments to explain what this function does. You're meant to use Google!
+// Returns a random integer from 0 to 9


You could add further comments to explain how Math.random() returns a decimal value which is then scaled to a desired range.

Agreed. It'll be helpful for collaborators to know what the random operator does.

Also, is 9 the highest output of this function? What if math.random selects 0.9, for example?

Oh, yes, you are right. Math.random() returns a decimal value, and it can be scaled more than just to 9. But if to speak just about my function - it returns form 0 to 9. Thank you, Shahid and Katie!

Schboostie · 2023-02-21T23:49:45Z

mandatory/4-tax.js

@@ -5,7 +5,9 @@
  Sales tax is 20% of the price of the product.
 */

-function calculateSalesTax() {}
+function calculateSalesTax(price) {
+  return price + price/5;


It can be useful to declare separate variables at stages of each operation. When calculations become more complexed it may be necessary to check various stages to see if and when mistakes occur.

Schboostie · 2023-02-21T23:50:51Z

mandatory/4-tax.js

@@ -17,7 +19,10 @@ function calculateSalesTax() {}
  Remember that the prices must include the sales tax (hint: you already wrote a function for this!)
 */

-function addTaxAndFormatCurrency() {}
+function addTaxAndFormatCurrency(number) {
+  let tax = calculateSalesTax(number);


I really like the use of the tax variable to break down the stages of the function.

Schboostie · 2023-02-21T23:55:59Z

extra/2-piping.js

 }

 const startingValue = 2;

 // Why can this code be seen as bad practice? Comment your answer.
-let badCode =
+let badCode = `£${(startingValue + 10 ) * 2}`


I can not see a comment to explain why this is bad code. Did you add one?

This could use a little work, as the exercise above asks you to use the functions (like you have below in goodCode). Why would all your functions on one line (like you have in goodCode) be bad? Hint - bugs, readability

I concentrated so much on JavaScript that I didn`t notice task "Comment your answer..." ))) I updated my code and pushed it

Schboostie · 2023-02-21T23:56:44Z

extra/2-piping.js

 }

 const startingValue = 2;

 // Why can this code be seen as bad practice? Comment your answer.
-let badCode =
+let badCode = `£${(startingValue + 10 ) * 2}`



My explanation was:

//Multiple methods are used in one line which makes it hard to determine the results from each methods execution. It is confusing and hard to follow.

Nice answer Schboostie

kjjwhitlock · 2023-02-22T14:02:31Z

Iryna, well done this is a fantastic effort! Really impressed with your work on the extra exercises too. Keep it up!

kjjwhitlock · 2023-02-22T13:31:43Z

mandatory/1-syntax-errors.js

-
-  return "The total is total";
+  let total = a + b;
+  return `The total is ${total}`;


kjjwhitlock · 2023-02-22T13:34:27Z

mandatory/2-logic-error.js

 }

 function multiply(a, b, c) {
-  a * b * c;
-  return;
+  return a * b * c;
 }


All functions looking good here, Iryna!

kjjwhitlock · 2023-02-22T13:40:51Z

mandatory/3-function-output.js

@@ -1,16 +1,20 @@
 // Add comments to explain what this function does. You're meant to use Google!
+// Returns a random integer from 0 to 9


Agreed. It'll be helpful for collaborators to know what the random operator does.

Also, is 9 the highest output of this function? What if math.random selects 0.9, for example?

kjjwhitlock · 2023-02-22T13:42:05Z

mandatory/3-function-output.js

 }

 function concatenate(firstWord, secondWord, thirdWord) {
  // Write the body of this function to concatenate three words together.
  // Look at the test case below to understand what this function is expected to return.
+
+   return firstWord.concat(' ', secondWord, ' ', thirdWord);


kjjwhitlock · 2023-02-22T13:44:59Z

mandatory/3-function-output.js

 function getRandomNumber() {
  return Math.random() * 10;
 }

 // Add comments to explain what this function does. You're meant to use Google!
+ //Concatenate strings,numbers, arrays:


Nice start but think we can add a little more detail here. What specifically is this function doing?

Also, concat can be used to concatanate strings and arrays, but can it concatanate numbers?

kjjwhitlock · 2023-02-22T13:48:47Z

extra/1-currency-conversion.js

@@ -15,7 +17,9 @@ function convertToUSD() {}
  They have also decided that they should add a 1% fee to all foreign transactions, which means you only convert 99% of the £ to BRL.
 */

-function convertToBRL() {}
+function convertToBRL(price) {
+  return Number(((price * 5.7)*0.99).toFixed(2));


This is smart and gets the job done, but it is trying to achieve too much on one line - making it vulnerable to bugs and difficult to read.

How can you take these steps and break them into separate lines?

kjjwhitlock · 2023-02-22T13:49:35Z

extra/2-piping.js


+function format(num) {
+  return `£${num}`


Nice string interpolation here!

kjjwhitlock · 2023-02-22T13:52:26Z

extra/2-piping.js

 }

 const startingValue = 2;

 // Why can this code be seen as bad practice? Comment your answer.
-let badCode =
+let badCode = `£${(startingValue + 10 ) * 2}`


This could use a little work, as the exercise above asks you to use the functions (like you have below in goodCode). Why would all your functions on one line (like you have in goodCode) be bad? Hint - bugs, readability

kjjwhitlock · 2023-02-22T13:52:51Z

extra/2-piping.js

 }

 const startingValue = 2;

 // Why can this code be seen as bad practice? Comment your answer.
-let badCode =
+let badCode = `£${(startingValue + 10 ) * 2}`



Nice answer Schboostie

kjjwhitlock · 2023-02-22T13:54:59Z

extra/2-piping.js


 /* BETTER PRACTICE */

-let goodCode =
+let goodCode = format(multiply(add(startingValue, 10), 2));


This does the job, but good code is highly readable and easy to modify so tends to be broken out into multiple lines. Can you break this out into steps?

kjjwhitlock · 2023-02-22T14:06:14Z

extra/3-magic-8-ball.js

+let allAnswers = [veryPositiveAnswers, positiveAnswers, negativeAnswers, veryNegativeAnswers];
+
+function findRandomIndex(max){
+  return  Math.floor(Math.random() * max);


Great use of max here!

kjjwhitlock · 2023-02-22T14:07:43Z

extra/3-magic-8-ball.js

+  console.log("The ball has shaken!");
+  let num1 = findRandomIndex(4);
+  let num2 = findRandomIndex(5);
+  return allAnswers[num1][num2];


Why are you returning two indices here?

Ah, I think I see. Do you need to call findRandomIndex within the shakeBall function so that it changes the output each time?

kjjwhitlock · 2023-02-22T14:13:35Z

extra/3-magic-8-ball.js

+
+  }
+
+function checkAnswer(answer) {


I am not sure what this is doing (am new to javascript). Could you please explain? Remember to focus on readability. Looks great though and it's awesome to see all the tests passing.

completed exercises

4baeecb

Schboostie reviewed Feb 21, 2023

View reviewed changes

kjjwhitlock reviewed Feb 22, 2023

View reviewed changes

kjjwhitlock approved these changes Feb 22, 2023

View reviewed changes

IrynaLypnyk and others added 3 commits February 22, 2023 22:16

update code

8bb8641

code refactoring

da10053

just to test if errors on github are still on github

950f3d8

ewintram added the reviewed label Mar 4, 2023

		@@ -1,16 +1,20 @@
		// Add comments to explain what this function does. You're meant to use Google!
		// Returns a random integer from 0 to 9

Uh oh!

london-10/iryna-lypnyk/completed-mandatory&extra-exercises #522

Are you sure you want to change the base?

london-10/iryna-lypnyk/completed-mandatory&extra-exercises #522

Uh oh!

Conversation

IrynaLypnyk commented Feb 21, 2023

Uh oh!

Schboostie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IrynaLypnyk Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IrynaLypnyk Feb 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kjjwhitlock commented Feb 22, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

IrynaLypnyk Feb 22, 2023 •

edited

Loading

IrynaLypnyk Feb 22, 2023 •

edited

Loading