This repository was archived by the owner on Jan 14, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 481
London 10 - Pouya Nasraei Ghomi - JavaScript-Core-1-Coursework-Week1 #530
Open
85pouya
wants to merge
2
commits into
CodeYourFuture:master
Choose a base branch
from
85pouya:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
// The syntax for these functions is valid but there are some errors, find them and fix them | ||
|
||
function trimWord(word) { | ||
return wordtrim(); | ||
return word.trim(); | ||
} | ||
|
||
function getStringLength(word) { | ||
return "word".length(); | ||
return word.length; | ||
} | ||
|
||
function multiply(a, b, c) { | ||
a * b * c; | ||
return; | ||
let multiply = a * b * c; | ||
return(multiply); | ||
} | ||
|
||
/* | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice one! |
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,10 @@ | |
Sales tax is 20% of the price of the product. | ||
*/ | ||
|
||
function calculateSalesTax() {} | ||
function calculateSalesTax(price) { | ||
let taxprice = price + price*0.2; | ||
return taxprice; | ||
} | ||
|
||
/* | ||
CURRENCY FORMATTING | ||
|
@@ -17,7 +20,10 @@ function calculateSalesTax() {} | |
Remember that the prices must include the sales tax (hint: you already wrote a function for this!) | ||
*/ | ||
|
||
function addTaxAndFormatCurrency() {} | ||
function addTaxAndFormatCurrency(price) { | ||
let taxprice = price + price*0.2; | ||
return taxprice = '£' + taxprice.toFixed(2); | ||
} | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Everything is fine. You can call 'calculateSalesTax' instead of rewriting the codes again. We call this 'DRY coding'. Your current way is fine, too. |
||
/* | ||
=================================================== | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Pouya, Good job! You forgot to create a variable into your function. I mean, try to add 'const' or 'let' before the word 'total'.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Ali-Jahankah for your feedback. I added 'let' before 'total'