This repository was archived by the owner on Jan 14, 2024. It is now read-only.
glasgow_6-Najah_Farah-javascript-week 1 #535
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dedekind561
suggested changes
Feb 28, 2023
There was a problem hiding this comment.
Hi there @nfarah22 ,
Well done on submitting your first piece of JS coursework!
At the moment, one of the test suites isn't passing - I can see this in the view on the PR. It says that 1 check has failed. Make sure you double check the tests again and fix the syntax errors you've got in this file.
| return a + b + c; | ||
| } | ||
|
|
||
| function introduceMe(name, age) | ||
| return `Hello, my {name}` is "and I am $age years old`; |
There was a problem hiding this comment.
Hi @nfarah22,
The code in 1-syntax-errors.js is still throwing a Syntax Error at the moment. Think you might need to double check this file.
|
|
||
| return "The total is total"; | ||
| return "The total is" + total; |
There was a problem hiding this comment.
Can you try refactoring line 13 to use template literals here?
| @@ -17,7 +20,10 @@ function calculateSalesTax() {} | |||
| Remember that the prices must include the sales tax (hint: you already wrote a function for this!) | |||
| */ | |||
|
|
|||
| function addTaxAndFormatCurrency() {} | |||
| function addTaxAndFormatCurrency(price) { | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these are my solutions to this weeks coursework
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?