Skip to content
This repository was archived by the owner on Jan 14, 2024. It is now read-only.
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions mandatory/1-syntax-errors.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
// There are syntax errors in this code - can you fix it to pass the tests?

function addNumbers(a b c) {
function addNumbers(a, b, c) {
return a + b + c;
}

function introduceMe(name, age)
return `Hello, my {name}` is "and I am $age years old`;
function introduceMe(name, age){
return `Hello, my name is ${name} and I am ${age} years old`;
}

function getTotal(a, b) {
total = a ++ b;
total = a + b;

return "The total is total";
return `The total is ${total}`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job using template literals here 👍

}

/*
Expand Down
8 changes: 4 additions & 4 deletions mandatory/2-logic-error.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
// The syntax for these functions is valid but there are some errors, find them and fix them

function trimWord(word) {
return wordtrim();
return word.trim();
}

function getStringLength(word) {
return "word".length();
return word.length;
}

function multiply(a, b, c) {
a * b * c;
return;
return a * b * c;

}

/*
Expand Down
6 changes: 5 additions & 1 deletion mandatory/3-function-output.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,19 @@
function getRandomNumber() {
return Math.random() * 10;
}
//Returns a random number between 0 & 10

// Add comments to explain what this function does. You're meant to use Google!
function combine2Words(word1, word2) {
return word1.concat(word2);
return word1.concat(word2);
}
//concat merges 2 arrays and creates a new one, so this would merge the 2 words

function concatenate(firstWord, secondWord, thirdWord) {
return `${firstWord} ${secondWord} ${thirdWord}`
// Write the body of this function to concatenate three words together.
// Look at the test case below to understand what this function is expected to return.

}

/*
Expand Down
15 changes: 13 additions & 2 deletions mandatory/4-tax.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@
Sales tax is 20% of the price of the product.
*/

function calculateSalesTax() {}
function calculateSalesTax(a) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've used a as a parameter name here. But this doesn't offer insight into what the parameter represents. Remember your code is designed to be read by others so always try to convey meaning when you choose variable names - sometimes this can be tricky!

subTotal = a * .2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
subTotal = a * .2;
let subTotal = a * .2;

When declaring your variables, you've ommitted the let/const keyword. This will still work but for reasons you'll learn about later this is bad practice ( you'll almost always declare variables with let/const )

total = subTotal + a;

return total;

}

/*
CURRENCY FORMATTING
Expand All @@ -17,7 +23,12 @@ function calculateSalesTax() {}
Remember that the prices must include the sales tax (hint: you already wrote a function for this!)
*/

function addTaxAndFormatCurrency() {}
function addTaxAndFormatCurrency(a) {
subTotal = a * .2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing here with let/const

total = subTotal + a;

return `£${total .toFixed(2)}`
}

/*
===================================================
Expand Down