This repository was archived by the owner on Jan 14, 2024. It is now read-only.
madotory4 #539
Open
madotory4 #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello there @SumayaT, |
|
Remember you can check out the Git cheatsheet - pay particular attention to the section I want to send my code to volunteers (Pushing). This section gives instructions on how to format your PR title. |
Dedekind561
suggested changes
Feb 28, 2023
| @@ -17,7 +20,11 @@ function calculateSalesTax() {} | |||
| Remember that the prices must include the sales tax (hint: you already wrote a function for this!) | |||
| */ | |||
|
|
|||
| function addTaxAndFormatCurrency() {} | |||
| function addTaxAndFormatCurrency(number) { | |||
| let currency = calculateSalesTax(number); | |||
There was a problem hiding this comment.
Is currency the best name for this variable here? What does the output of the function calculateSalesTax represent? Thinking of how to answer this question will help you to improve your variable name.
|
|
||
| return "The total is total"; | ||
| return "The total is " + total; |
There was a problem hiding this comment.
Can you try refactoring line 14 to make use of template literals?
| } | ||
|
|
||
| function multiply(a, b, c) { | ||
| a * b * c; | ||
| return; | ||
| return a * b * c; |
There was a problem hiding this comment.
👓 Watch out for your indentation here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Volunteers: Are you marking this coursework? You can find a guide on how to mark this coursework in
HOW_TO_MARK.mdin the root of this repositoryYour Details
Homework Details
Notes
What did you find easy?
What did you find hard?
What do you still not understand?
Any other notes?