-
-
Notifications
You must be signed in to change notification settings - Fork 481
london_10-Saliha_Popal-JavaScript-Core-1-Coursework-Week1 #540
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,26 +16,30 @@ | |
the final result to the variable goodCode | ||
*/ | ||
|
||
function add() { | ||
|
||
function add(a, b) { | ||
return a + b; | ||
} | ||
|
||
function multiply() { | ||
|
||
function multiply(a, b) { | ||
return a * b; | ||
} | ||
|
||
function format() { | ||
|
||
function format(value) { | ||
let currency = "£" | ||
return "£" + value; | ||
} | ||
|
||
const startingValue = 2; | ||
|
||
// Why can this code be seen as bad practice? Comment your answer. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question: have we answered the question here There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the starting value is not a number, the code may return an error. |
||
let badCode = | ||
let badCode = format(multiply(add(startingValue, 10), 2)); | ||
|
||
/* BETTER PRACTICE */ | ||
|
||
let goodCode = | ||
let sum = add(startingValue, 10); | ||
let multiplies = multiply(sum , 2); | ||
let goodCode = format(multiplies); | ||
// let goodCode | ||
|
||
/* ======= TESTS - DO NOT MODIFY ===== | ||
There are some Tests in this file that will help you work out if your code is working. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,52 +14,73 @@ | |
|
||
Below are the possible answers: | ||
|
||
## Very positive | ||
It is certain. | ||
It is decidedly so. | ||
Without a doubt. | ||
Yes - definitely. | ||
You may rely on it. | ||
|
||
## Positive | ||
As I see it, yes. | ||
Most likely. | ||
Outlook good. | ||
Yes. | ||
Signs point to yes. | ||
|
||
## Negative | ||
Reply hazy, try again. | ||
Ask again later. | ||
Better not tell you now. | ||
Cannot predict now. | ||
Concentrate and ask again. | ||
|
||
## Very negative | ||
Don't count on it. | ||
My reply is no. | ||
My sources say no. | ||
Outlook not so good. | ||
Very doubtful. | ||
*/ | ||
**/ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. praise: nice converting them all to arrays of strings |
||
|
||
let veryPositive = [ | ||
"It is certain.", | ||
"It is decidedly so.", | ||
"Without a doubt.", | ||
"Yes - definitely.", | ||
"You may rely on it.", | ||
] | ||
|
||
|
||
let Positive = [ | ||
"As I see it, yes.", | ||
"Most likely.", | ||
"Outlook good.", | ||
"Yes.", | ||
"Signs point to yes." | ||
] | ||
|
||
|
||
let Negative =[ | ||
"Reply hazy, try again.", | ||
"Ask again later.", | ||
"Better not tell you now.", | ||
"Cannot predict now.", | ||
"Concentrate and ask again." | ||
] | ||
|
||
|
||
let veryNegative = [ | ||
"Don't count on it.", | ||
"My reply is no.", | ||
"My sources say no.", | ||
"Outlook not so good.", | ||
"Very doubtful." | ||
] | ||
|
||
// This should log "The ball has shaken!" | ||
// and return the answer. | ||
function shakeBall() { | ||
//Write your code in here | ||
console.log("The ball has shaken!"); | ||
let randomIndex = Math.floor(Math.random() * allAnswers.length); | ||
return allAnswers[randomIndex]; | ||
} | ||
|
||
/* | ||
This function should say whether the answer it is given is | ||
- very positive | ||
- positive | ||
- negative | ||
- very negative | ||
|
||
This function should expect to be called with any value which was returned by the shakeBall function. | ||
*/ | ||
//This function should say whether the answer it is given is | ||
let allAnswers =[ | ||
...veryPositive, | ||
...Positive, | ||
...Negative, | ||
...veryNegative, | ||
] | ||
|
||
|
||
//This function should expect to be called with any value which was returned by the shakeBall function. | ||
|
||
function checkAnswer(answer) { | ||
//Write your code in here | ||
if(veryPositive.includes(answer)){ | ||
return "very positive"; | ||
} else if (Positive.includes(answer)){ | ||
return "Positive"; | ||
} else if (Negative.includes(answer)){ | ||
return "Negative"; | ||
} else if(veryNegative.includes(answer)){ | ||
return "very negative"; | ||
} | ||
} | ||
|
||
/* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,17 @@ | ||
// There are syntax errors in this code - can you fix it to pass the tests? | ||
|
||
function addNumbers(a b c) { | ||
function addNumbers(a, b, c) { | ||
return a + b + c; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment: Well done! Same as answers as me. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good work Saliha. 👍 |
||
|
||
function introduceMe(name, age) | ||
return `Hello, my {name}` is "and I am $age years old`; | ||
function introduceMe(name, age){ | ||
return `Hello, my name is ${name} and I am ${age} years old`; | ||
} | ||
|
||
function getTotal(a, b) { | ||
total = a ++ b; | ||
total = a + b; | ||
|
||
return "The total is total"; | ||
return `The total is ${total}`; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. praise: Nice use of template literals here |
||
} | ||
|
||
/* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,15 @@ | ||
// The syntax for these functions is valid but there are some errors, find them and fix them | ||
|
||
function trimWord(word) { | ||
return wordtrim(); | ||
return word.trim(); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment: Looks good and same answers as me on all three. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good work Saliha. 👍 |
||
|
||
function getStringLength(word) { | ||
return "word".length(); | ||
return word.length; | ||
} | ||
|
||
function multiply(a, b, c) { | ||
a * b * c; | ||
return; | ||
return a * b * c; | ||
} | ||
|
||
/* | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,17 @@ | ||
// Add comments to explain what this function does. You're meant to use Google! | ||
function getRandomNumber() { | ||
return Math.random() * 10; | ||
// Math.random generate a number between 1 to 10. That is not a whole number nor 1. In order to get a whole number multiply your answer to 10: Math.random() * 10 | ||
} | ||
|
||
// Add comments to explain what this function does. You're meant to use Google! | ||
function combine2Words(word1, word2) { | ||
return word1.concat(word2); | ||
// this function combine two strings and make a new string. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment: Good description. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good work Saliha. 👍 |
||
} | ||
|
||
function concatenate(firstWord, secondWord, thirdWord) { | ||
// Write the body of this function to concatenate three words together. | ||
// Look at the test case below to understand what this function is expected to return. | ||
return firstWord.concat(' ',secondWord, ' ',thirdWord,); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Comment: same answer as me. |
||
|
||
/* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Math.round(priceInBRL * 100) / 100; is used in
JavaScript-Core-1-Coursework-Week1-Solution