-
-
Notifications
You must be signed in to change notification settings - Fork 482
glasgow class 6-siver omar-javascript 1-week1 #548
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,16 @@ | ||
// There are syntax errors in this code - can you fix it to pass the tests? | ||
// There are syntax errors in this code - can you fix it to pass the tests?// | ||
|
||
function addNumbers(a b c) { | ||
function addNumbers(a ,b ,c) { | ||
return a + b + c; | ||
} | ||
|
||
function introduceMe(name, age) | ||
return `Hello, my {name}` is "and I am $age years old`; | ||
|
||
function introduceMe(name, age){ | ||
return `Hello, my name is ${name} and I am ${age} years old`; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Great job on using string interpolation! |
||
} | ||
function getTotal(a, b) { | ||
total = a ++ b; | ||
total = a + b; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This code will work, but we should always use either let or const when declaring a new variable 😅 Do you know why that is? |
||
|
||
return "The total is total"; | ||
return `The total is ${total}`; | ||
} | ||
|
||
/* | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💯 Perfect! |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,20 @@ | ||
// Add comments to explain what this function does. You're meant to use Google! | ||
function getRandomNumber() { | ||
return Math.random() * 10; | ||
|
||
} | ||
// It generates a random number using Math.random() and it multiplies by 10 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Exactly correct. ❓ Could you perhaps explain what the output of As a heads up - It's usually common to put comments above the code they are describing! |
||
|
||
// Add comments to explain what this function does. You're meant to use Google! | ||
function combine2Words(word1, word2) { | ||
return word1.concat(word2); | ||
} | ||
|
||
// the concat() method is used to merge two or more arrays. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ❓ Is it just arrays that can use the |
||
function concatenate(firstWord, secondWord, thirdWord) { | ||
// Write the body of this function to concatenate three words together. | ||
// Look at the test case below to understand what this function is expected to return. | ||
return firstWord.concat(" ", secondWord, " ", thirdWord); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Great use of the |
||
} | ||
|
||
/* | ||
=================================================== | ||
======= TESTS - DO NOT MODIFY BELOW THIS LINE ===== | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,10 @@ | |
Sales tax is 20% of the price of the product. | ||
*/ | ||
|
||
function calculateSalesTax() {} | ||
function calculateSalesTax(productPrice) { | ||
let salesTax = productPrice * 0.2; | ||
return productPrice + salesTax | ||
Comment on lines
+9
to
+10
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
} | ||
|
||
/* | ||
CURRENCY FORMATTING | ||
|
@@ -17,8 +20,12 @@ function calculateSalesTax() {} | |
Remember that the prices must include the sales tax (hint: you already wrote a function for this!) | ||
*/ | ||
|
||
function addTaxAndFormatCurrency() {} | ||
function addTaxAndFormatCurrency(price) { | ||
let productPriceRes = calculateSalesTax(price); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A really hard thing to do is choose variable names - Variable names should make it clear at a glance what is stored in the variable.
|
||
|
||
return `£${productPriceRes.toFixed(2)}`; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 Great way to solve this! |
||
|
||
} | ||
/* | ||
=================================================== | ||
======= TESTS - DO NOT MODIFY BELOW THIS LINE ===== | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
❓ Have you tried running prettier on your code? The formatting on these commas is a little inconsistent with the rest of the file