Skip to content
This repository has been archived by the owner on Jan 14, 2024. It is now read-only.

glasgow class 6-siver omar-javascript 1-week1 #548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions mandatory/1-syntax-errors.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
// There are syntax errors in this code - can you fix it to pass the tests?
// There are syntax errors in this code - can you fix it to pass the tests?//

function addNumbers(a b c) {
function addNumbers(a ,b ,c) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!
❓ Have you tried running prettier on your code? The formatting on these commas is a little inconsistent with the rest of the file

return a + b + c;
}

function introduceMe(name, age)
return `Hello, my {name}` is "and I am $age years old`;

function introduceMe(name, age){
return `Hello, my name is ${name} and I am ${age} years old`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great job on using string interpolation!

}
function getTotal(a, b) {
total = a ++ b;
total = a + b;
Copy link

@KieranBond KieranBond Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code will work, but we should always use either let or const when declaring a new variable 😅

Do you know why that is?


return "The total is total";
return `The total is ${total}`;
}

/*
Expand Down
7 changes: 3 additions & 4 deletions mandatory/2-logic-error.js

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Perfect!

Original file line number Diff line number Diff line change
@@ -1,16 +1,15 @@
// The syntax for these functions is valid but there are some errors, find them and fix them

function trimWord(word) {
return wordtrim();
return word.trim();
}

function getStringLength(word) {
return "word".length();
return word.length;
}

function multiply(a, b, c) {
a * b * c;
return;
return a * b * c;
}

/*
Expand Down
6 changes: 4 additions & 2 deletions mandatory/3-function-output.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,20 @@
// Add comments to explain what this function does. You're meant to use Google!
function getRandomNumber() {
return Math.random() * 10;

}
// It generates a random number using Math.random() and it multiplies by 10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly correct.

❓ Could you perhaps explain what the output of Math.random() is? Did you happen to find any documentation on this to help explain it?

As a heads up - It's usually common to put comments above the code they are describing!


// Add comments to explain what this function does. You're meant to use Google!
function combine2Words(word1, word2) {
return word1.concat(word2);
}

// the concat() method is used to merge two or more arrays.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ Is it just arrays that can use the concat() method? Did you come across any useful documentation when investigating?

function concatenate(firstWord, secondWord, thirdWord) {
// Write the body of this function to concatenate three words together.
// Look at the test case below to understand what this function is expected to return.
return firstWord.concat(" ", secondWord, " ", thirdWord);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great use of the concat function!

}

/*
===================================================
======= TESTS - DO NOT MODIFY BELOW THIS LINE =====
Expand Down
11 changes: 9 additions & 2 deletions mandatory/4-tax.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,10 @@
Sales tax is 20% of the price of the product.
*/

function calculateSalesTax() {}
function calculateSalesTax(productPrice) {
let salesTax = productPrice * 0.2;
return productPrice + salesTax
Comment on lines +9 to +10

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}

/*
CURRENCY FORMATTING
Expand All @@ -17,8 +20,12 @@ function calculateSalesTax() {}
Remember that the prices must include the sales tax (hint: you already wrote a function for this!)
*/

function addTaxAndFormatCurrency() {}
function addTaxAndFormatCurrency(price) {
let productPriceRes = calculateSalesTax(price);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A really hard thing to do is choose variable names - Variable names should make it clear at a glance what is stored in the variable.

Res leaves it a little ambiguous and up to interpretation, partly because it is a shortened word. Perhaps something like productPriceWithTax would be clearer? What do you think?


return `£${productPriceRes.toFixed(2)}`;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great way to solve this!


}
/*
===================================================
======= TESTS - DO NOT MODIFY BELOW THIS LINE =====
Expand Down