NW6 | Sabella Fisseha | JS2 | To Do List | WEEK 3

[Sabella-8]

Learners, PR Template

Self checklist

• I have committed my files one by one, on purpose, and for a reason
• I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
• I have tested my changes
• My changes follow the style guide
• My changes meet the requirements of this task

Changelist

Briefly explain your PR.

Questions

Ask any questions you have for your reviewer.

[netlify]

✅ Deploy Preview for cute-gaufre-e4b4e5 ready!

Name	Link
🔨 Latest commit	4892dbd
🔍 Latest deploy log	https://app.netlify.com/sites/cute-gaufre-e4b4e5/deploys/65ae9a049b80420008e6fea2
😎 Deploy Preview	https://deploy-preview-214--cute-gaufre-e4b4e5.netlify.app/week-3/todo-list
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[JayMayer]

In the end I don't think you used a custom font, so this <link> tag can be removed. We want to make sure that the site loads quickly for users and doesn't download unnecessary files, so removing this is an easy performance win! 💯

[JayMayer]

In this file, there's two large chunks of code that are very similar, inside the populateTodoList and addNewTodo functions. Generally, we don't want to re-use code (a concept called DRY - Don't Repeat Yourself). Repeating code can make it difficult to make a change in the future - it's nice to only have to update code in one place

As a starting point - maybe some of the repeated code could be extracted into its own function? Both seem to be creating a new todo element, so maybe a function called createTodo or similar would be a good place for the code

[JayMayer]

Wow! This is great work Sabella! You've hit all the requirements and completed the advanced challenge!