This repository was archived by the owner on Dec 18, 2024. It is now read-only.
NW6 | Sabella Fisseha | JS2 Module-To Do-List App | WEEK 4 #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-gaufre-e4b4e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bunday
suggested changes
Jan 27, 2024
| <ul id="todo-list"></ul> | ||
| <form> | ||
| <div> | ||
| <input type="text" placeholder="New todo..." id="textboxinput" /> |
There was a problem hiding this comment.
you should have the deadline date right here, it should be set after the user enter the todo name
|
|
||
|
|
||
| add.addEventListener("click", () => { | ||
| clickCount++; |
There was a problem hiding this comment.
instead of using the number of counts to determine the status of the todo. you can make use of the boolean todo completed status on each todo which you can toggle. That is s cleaner way to do it.
| function deleteAllCompletedTodos() { | ||
| // Write your code here... | ||
| const del = document.getElementById("remove-all-completed"); |
There was a problem hiding this comment.
this function isnt implemented correctly, when clicked, it removes all todos on the board. You should rewrite this function to filter out todos that has their completed status as true
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.