This repository was archived by the owner on Dec 18, 2024. It is now read-only.
NW-6 | Fikret Ellek | JS2| [TECH ED] Slideshow-Extra| WEEK-4 #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-gaufre-e4b4e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
musayuksel
reviewed
Jan 29, 2024
| previousPhoto(); | ||
| }, 2000); | ||
| clearInterval(autoPlayForward); |
There was a problem hiding this comment.
I love this! it clears other intervals when you change the slide direction - such a thoughtful touch! Well done!
| nextPhoto(); | ||
| }, 2000); | ||
| clearInterval(autoPlayBackward); |
Comment on lines
+111
to
+114
| imgBtn.setAttribute("id", `img${i}`); | ||
| imgBtn.classList.add("navBtn"); | ||
| navContainer.appendChild(imgBtn); |
There was a problem hiding this comment.
Same here as I mentioned in the previous message, you created the element and then appended it to the DOM. Well done!
|
|
||
| .btn-container { | ||
| display: flex; | ||
| flex-direction: row; |
There was a problem hiding this comment.
Nice design, well done. Small note: you don't need to specify flex-direction: row; since the default value is already row :)
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.