This repository has been archived by the owner on Dec 18, 2024. It is now read-only.
NW6 | Rabia Avci | JS2 Module | [TECH ED]Complete week 2 exercises | Week 2 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cute-gaufre-e4b4e5 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Ara225
reviewed
Mar 10, 2024
| const firstIndex = Math.floor(middleIndex); | ||
| const secondIndex = Math.round(middleIndex); | ||
|
|
||
| return (list[firstIndex-1]+list[secondIndex-1])/2; |
Ara225
reviewed
Mar 10, 2024
|
|
||
| test("given an array with strings or numbers, it removes the duplicate values", () => { | ||
| expect(dedupe([5, 1, 'a', 'a', 2, 'b', 3, 3, 8, 8])).toStrictEqual([5, 1, 'a', 2,'b', 3, 8]); | ||
| }); |
| output.push(input[i]); | ||
| } | ||
| } | ||
| return Math.max(...output); |
There was a problem hiding this comment.
Amazing, don't forget to tidy commented out code :)
|
|
||
| test("given an array with non-number values, returns max, ignore non-numeric values", () => { | ||
| expect(max(["17", 12, "c", 5.4])).toBe(12); | ||
| }); |
|
|
||
|
|
||
|
|
||
| module.exports = sum; |
|
|
||
| test("given an array with non-number values, returns the sum of the numerical elements, ignore non-numeric values", () => { | ||
| expect(sum(["17", 12, "c", 5.4])).toBe(17.4); | ||
| }); |
|
|
||
| test.todo("creates a country currency code lookup for multiple codes"); | ||
| module.exports = createLookup; |
| CA: "CAD", | ||
| GB: "GBP", | ||
| }); | ||
| }); |
| return counts; | ||
| } | ||
|
|
||
| module.exports= tally; |
|
|
||
| test("When passed an invalid input like a string to tally, it should throw an error", () => { | ||
| expect(() => { tally("invalid input");}).toThrow("Input must be an array"); | ||
| }) |
| // d) Explain why the current return value is different from the target output | ||
|
|
||
| // he current return value is different from the target output due to a mistake in the way the invert function is assigning values to the invertedObj. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.