Manchester | ITP-May-2025 | Chukwuemeke Ajuebor | Module-Structuring-and-Testing-Data | Sprint 3 #674

AjueborChukwuemeke · 2025-07-21T11:15:20Z

Learners, PR Template

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

Briefly explain your PR

In this PR I worked on testing the code to ensure it behaves as is expected subjected to different scenarios or given different inputs.
Started first with console.assert and then using jest to carry out better code efficient ways of testing code.

Questions
None

kfklein15 · 2025-07-22T09:13:18Z

Hi, the PR description is missing. Can you please update it accordingly to the template? Thanks

CameronDowner

This is looking really good!

I've left a few comments - some highlighting edge cases & some highlighting areas to improve readability and code clarity, rather than logic or correctness.

Overall very strong submission

Let me know if you have any questions

CameronDowner · 2025-07-26T09:07:32Z

Sprint-3/1-key-implement/2-is-proper-fraction.js

+// Explanation: Even though this gives a zero value it still returns true 
+//so we expect it to be true
+const zeroNumeratorFraction = isProperFraction(0, 3); 
+assertEquals(zeroNumeratorFraction, "input non-zero above");


Would we expect 0/3 to be an 'error' case?

CameronDowner · 2025-07-26T09:08:17Z

Sprint-3/1-key-implement/2-is-proper-fraction.js

+// target output: false
+// Explanation: This actually outputs false even though the operation is practically impossible.
+const zeroZeroFraction = isProperFraction(0, 0); 
+assertEquals(zeroZeroFraction, "put numbers above and below");


Does the numerator need to be non-zero?

CameronDowner · 2025-07-26T09:09:55Z

Sprint-3/1-key-implement/2-is-proper-fraction.js

@@ -8,7 +8,14 @@
 // write one test at a time, and make it pass, build your solution up methodically

 function isProperFraction(numerator, denominator) {
-    if (numerator < denominator) return true;
+    if (numerator === 0 && denominator === 0) return "put numbers above and below";


Stretch: if we re-order these if statements, could we reduce the number of conditions we need to check? Each condition adds complexity to our code

For example, if I check numerator === 0 first, will I need to check numerator !== 0 later?

CameronDowner · 2025-07-26T09:12:25Z

Sprint-3/1-key-implement/3-get-card-value.js

@@ -8,7 +8,15 @@
 // write one test at a time, and make it pass, build your solution up methodically
 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
-    if (rank === "A") return 11;
+    rank = card[0]


This is missing a declaration - what do we need to put in front of this variable assignment?

CameronDowner · 2025-07-26T09:15:59Z

Sprint-3/1-key-implement/3-get-card-value.js

+    else if (Number(rank) >= 2 && Number(rank) <= 10) return Number(rank);
+    //else return "Invalid card rank.";
+    /* else if (card.length > 3 && !(card[0] === "1" && card[1] === "0" && isNaN(card[2]))) 
+      return "Invalid card rank"; */
 }

 // You need to write assertions for your function to check it works in different cases


Could you add this test case & see what it returns?

const tenOfHearts = getCardValue("10♥"); assertEquals(tenOfHearts, 10);

CameronDowner · 2025-07-26T09:25:16Z

Sprint-3/3-mandatory-practice/implement/count.js

+    // The while loop goes through the string, one character at a time
+    // gets the character at the current position and
+    // checks if it matches the character we're looking for
+    while (i < stringOfCharacters.length) {


This looks good - if there another type of loop we could use here? Potentially to remove the need for i?

Looks good - we could also use a for...of loop here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...of#iterating_over_a_string

const iterable = "boo"; for (const value of iterable) { console.log(value); } // "b" // "o" // "o"

CameronDowner · 2025-07-26T09:26:34Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js

+ let lastDigit = numStr[numStr.length - 1]; // Get last digit as string
+ let lastTwoDigits = numStr.slice(-2); // Get last two digits as string
+
+  //We have three special cases for the numbers 11, 12, 13


Really nice use of comments here - super easy to read

CameronDowner · 2025-07-26T09:26:48Z

Sprint-3/3-mandatory-practice/implement/get-ordinal-number.js

@@ -1,5 +1,18 @@
 function getOrdinalNumber(num) {
- return "1st";
+  let numStr = num.toString(); // Convert number to string


Do these need to be let?

CameronDowner · 2025-07-26T09:28:09Z

Sprint-3/3-mandatory-practice/implement/repeat.js

+function repeat(str,count) {
+    if (count < 0) 
+    return "negative counts invalid";
+    else if (count === 0) return "";


What happens if I call str.repeat(0) or str.repeat(1)?

CameronDowner · 2025-07-26T09:28:22Z

Sprint-3/3-mandatory-practice/implement/repeat.js

+    let repeated = str.repeat(count)    
+    return repeated;


Do we need to assign this to a variable before returning?

CameronDowner · 2025-08-02T12:37:27Z

This is looking good & you have addressed all issues / blocking comments 🙂

Happy to mark as complete, but there a couple comments remaining that would help improve your code further so worth having a look if you have time

AjueborChukwuemeke added 9 commits July 13, 2025 09:24

1-1

3a0c9d0

1-2

f586e60

1-3

59d50b8

2-1

a0349bc

2-2

7452269

2-3

71764ee

3-1-count

099824c

3-2-repeat

cbdfa96

3-3-get-ordinal number

7d1d62c

AjueborChukwuemeke added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 21, 2025

AjueborChukwuemeke mentioned this pull request Jul 21, 2025

MANCHESTER | Structuring and testing data | Chukwuemeke Ajuebor AjueborChukwuemeke/My-Coursework-Planner#43

Open

CameronDowner added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 26, 2025

CameronDowner reviewed Jul 26, 2025

View reviewed changes

CameronDowner added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jul 26, 2025

reviews_updated

10d7b40

AjueborChukwuemeke added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jul 27, 2025

CameronDowner added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 2, 2025

CameronDowner added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Aug 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Manchester | ITP-May-2025 | Chukwuemeke Ajuebor | Module-Structuring-and-Testing-Data | Sprint 3 #674

Manchester | ITP-May-2025 | Chukwuemeke Ajuebor | Module-Structuring-and-Testing-Data | Sprint 3 #674

Uh oh!

AjueborChukwuemeke commented Jul 21, 2025 •

edited

Loading

Uh oh!

kfklein15 commented Jul 22, 2025

Uh oh!

CameronDowner left a comment

Uh oh!

CameronDowner Jul 26, 2025

Uh oh!

CameronDowner Jul 26, 2025

Uh oh!

CameronDowner Jul 26, 2025

Uh oh!

CameronDowner Jul 26, 2025

Uh oh!

CameronDowner Jul 26, 2025

Uh oh!

CameronDowner Jul 26, 2025

Uh oh!

CameronDowner Aug 2, 2025

Uh oh!

CameronDowner Jul 26, 2025

Uh oh!

CameronDowner Jul 26, 2025

Uh oh!

CameronDowner Jul 26, 2025

Uh oh!

CameronDowner Jul 26, 2025

Uh oh!

CameronDowner commented Aug 2, 2025

Uh oh!

Uh oh!

Uh oh!

Manchester | ITP-May-2025 | Chukwuemeke Ajuebor | Module-Structuring-and-Testing-Data | Sprint 3 #674

Are you sure you want to change the base?

Manchester | ITP-May-2025 | Chukwuemeke Ajuebor | Module-Structuring-and-Testing-Data | Sprint 3 #674

Uh oh!

Conversation

AjueborChukwuemeke commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

kfklein15 commented Jul 22, 2025

Uh oh!

CameronDowner left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CameronDowner commented Aug 2, 2025

Uh oh!

Uh oh!

AjueborChukwuemeke commented Jul 21, 2025 •

edited

Loading