NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | coursework/sprint-3-implement-and-rewrite #709

TzeMingHo · 2025-09-23T16:45:39Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

For the 3 exercises, I have created assert conditions and tests for each case, as well as some stretch cases.

…ixed the conflict with a new variable name

…with parameter

…to 1 decimal

…wer case to upper case and replace all space with underline

…toPounds with input condition checks

jenny-alexander

Good job covering most test cases @TzeMingHo - I left a few comments for you to review.

jenny-alexander · 2025-10-08T00:50:26Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

 // complete the rest of the tests and cases
 // write one test at a time, and make it pass, build your solution up methodically

 function isProperFraction(numerator, denominator) {


Your isProperFraction works well. However, if you wanted to simplify it even more, you could try:

// this will return either true or false return (Math.abs(numerator) < Math.abs(denominator));

jenny-alexander · 2025-10-08T01:16:31Z

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

What would happen if I run the test with:

angle: 'ten'

angle: 1000

angle: -22

angle: null

jenny-alexander · 2025-10-08T01:19:29Z

Sprint-3/1-implement-and-rewrite-tests/implement/2-is-proper-fraction.js

+// Input: numerator = "a", denominator = 2
+// target output: false
+// Explanation: The function should handle non-numeric inputs gracefully. In this case, we choose to return false.
+const invalidInputs = isProperFraction("a", 2);


👏 Good job making sure that 'unhappy path' is tested.

jenny-alexander · 2025-10-08T01:29:32Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

When I run your tests, I get this result:
Assertion failed: Expected 1♠ to equal Error: Invalid card rank
Assertion failed: Expected Z♠ to equal Error: Invalid card rank
Assertion failed: Expected to equal Error: Invalid card rank

Can you take a look?

jenny-alexander · 2025-10-08T01:54:56Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

I tried a few more 'unhappy path' tests:

card value of true

card value of 22

card value of null

I was expecting ('Error: Invalid card rank').

jenny-alexander · 2025-10-08T01:55:55Z

package-lock.json

I think you included this file by mistake.

jenny-alexander

You're almost there! Most everything is passing now except /implement/3-get-card-value.js.

jenny-alexander · 2025-10-11T01:22:48Z

Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

 // Then, write the next test! :) Go through this process until all the cases are implemented

 function getAngleType(angle) {
+  if (


I see where you are going with this. :)
It can be simplified to this:

if (angle === null || isNaN(Number(angle))) { return "Input should be a number or a number in string"; }

⏫ You don't have to modify your code - I am simply pointing out a small improvement for 'next time' you do something similar to this.

jenny-alexander · 2025-10-11T01:29:17Z

Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js

 // just make one change at a time -- don't rush -- programmers are deep and careful thinkers
 function getCardValue(card) {
+  const errorMessage =
+    "Error: Invalid card rank. Input should be a string in the format 'R♠', where R is 2-10, J, Q, K, or A, followed by either ♠, ♥, ♦, or ♣.";


I suggest keeping the error message simple here:
'Error: Invalid card rank'

Right now, your tests are failing because the message you are expecting isn't the same as the one you are receiving. If you change the error message to 'Error: Invalid rank', it should pass correctly.

💡 Make sure that you run your tests before you submit your PR.

jenny-alexander · 2025-10-11T01:32:16Z

Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/3-get-card-value.test.js

+});
 // Case 5: Handle Invalid Cards:
+const errorMessage =
+  "Error: Invalid card rank. Input should be a string in the format 'R♠', where R is 2-10, J, Q, K, or A, followed by either ♠, ♥, ♦, or ♣.";


I suggest changing the error message back to something more simple and readable: Error: Invalid card rank.

jenny-alexander · 2025-10-12T22:36:21Z

Your PR looks good now. Good job!

TzeMingHo added 21 commits September 18, 2025 14:06

npm installed

9d43b8b

In 1 key-errors, made a preditions, explained the syntax error, and f…

150a780

…ixed the conflict with a new variable name

In 1-key-errors, deleted unwanted variable, and console.log function …

8fdb210

…with parameter

In 1-key-errors/2.js, replacing 3 with num as parameter

24f2d3c

In 2-mandatory-debug/0.js, updated return in the function

96ebf89

In 2-mandatory-debug/1.js, updated return inline with a+b

b2f87c5

In 2-mandatory-debug/2.js, adding a parameter in the function

b73f73f

In 3-mandatory-implement/1-bmi.js, filled in the function to get bmi …

72112ca

…to 1 decimal

In 3-mandatory-implement/2-cases.js, created a function to convert lo…

a505558

…wer case to upper case and replace all space with underline

In 3-mandatory-implement/3-to-pounds.js, created a reusable function …

6c1636f

…toPounds with input condition checks

In 4-mandatory-interpret/time-format.js, filled in answers

401db2b

In 5-stretch-extend/format-time.js, tried edge cases and invalid inputs

5733d12

correcting padStart for minutes String

096632e

Remove package-lock.json from pull request

b0fe035

ignore package-lock.json

7a2b0a1

adding 5 tests and passing 5 tests for 1-get-angle-type

096f9b6

finsihed 4 cases and tests of proper fraction, start doing stretch cases

5245e20

adding 9 stretch tests in proper fraction

bc00dfc

adding tests for card values in blackjack

bc1b331

restore sprint-2 from origin/main

51eedee

restore gitignore from origin/main

6c04424

TzeMingHo added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 23, 2025

jenny-alexander self-requested a review October 4, 2025 13:55

jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 4, 2025

jenny-alexander suggested changes Oct 8, 2025

View reviewed changes

jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 8, 2025

jenny-alexander reviewed Oct 8, 2025

View reviewed changes

package-lock.json Outdated

Copy link

jenny-alexander Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you included this file by mistake.

TzeMingHo added 5 commits October 8, 2025 13:18

adding more tests for different types of input

3c8fe4f

simplified return statement in proper-fractoin

6166064

adding tests and condition checks for different types of input

4b1ad2d

updated assertion tests and added input type tests for card value

892f63b

restore package-lock.json from origin/main

f14ee5c

TzeMingHo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 8, 2025

jenny-alexander suggested changes Oct 11, 2025

View reviewed changes

jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 11, 2025

TzeMingHo added 2 commits October 12, 2025 00:04

made the Error message simplier

76ad0cc

tried simplified the condition checks in get angle type

8b8773c

TzeMingHo added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 11, 2025

jenny-alexander added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 12, 2025

TzeMingHo mentioned this pull request Oct 13, 2025

25-IPT-Sep | Structuring and testing data | TzeMing Ho TzeMingHo/My-Coursework-Planner#25

Open

Uh oh!

NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | coursework/sprint-3-implement-and-rewrite #709

Are you sure you want to change the base?

NW | 25-ITP-Sep | TzeMing Ho | Sprint 3 | coursework/sprint-3-implement-and-rewrite #709

Uh oh!

Conversation

TzeMingHo commented Sep 23, 2025

Learners, PR Template

Changelist

Uh oh!

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jenny-alexander commented Oct 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants