Glasgow | 25-ITP-SEP | Shreef Ibrahim | Sprint 3 | Coursework #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreefAhmedM
added
the
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
reviewed
Oct 7, 2025
| // write one test at a time, and make it pass, build your solution up methodically | ||
| // just make one change at a time -- don't rush -- programmers are deep and careful thinkers | ||
| function getCardValue(card) { | ||
| let rank = card.length === 1 ? card : card.slice(0, -1); |
There was a problem hiding this comment.
What circumstances would you have a card of length 1? A card in this case is always a rank + a symbol
| }); | ||
| // Case 3: Handle Face Cards (J, Q, K): | ||
| test("should return the value 10, a card with a rank of ('10', 'J', 'Q', or 'K')", () => { | ||
| const aceofSpades = getCardValue("K"); |
There was a problem hiding this comment.
Same comment I gave above - This is a king, but which king, hearts? spades?
| if (last2Digit >= 11 && last2Digit <= 13) { | ||
| return num + "th"; | ||
| } | ||
| if (las1Digit === 1) { |
There was a problem hiding this comment.
When you have a long series of if checks like this, is there another conditional structure that might be more appropriate to use?
| } | ||
|
|
||
| module.exports = passwordValidator; | ||
| if (oldPassword.includes(password)) { |
There was a problem hiding this comment.
Could you simplify this final check?
LonMcGregor
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Her is JavaScript challenges tasks covering running test, error fixing, code interpretation, and a stretch exploration activity.