London | 25-ITP-May | Alexandru Pocovnicu | Sprint 2 | Acoursework #728
+164
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…line with"return" otherwise a semicolon would be automatically inserted
alexandru-pocovnicu
added
the
Needs Review
cjyuan
reviewed
Oct 12, 2025
Comment on lines
+18
to
+28
| let sqh=height*height; | ||
| let bmi=weight/sqh; | ||
| let bmiS=bmi.toString() | ||
|
|
||
|
|
||
| if(bmiS.includes(".")){ | ||
| let dotBmiS=bmiS.indexOf(".") | ||
| return (Number(bmiS.slice(0,dotBmiS+2))) | ||
| } return bmi | ||
|
|
||
| } |
There was a problem hiding this comment.
- Indentation is a bit off. Can you improve the indentation? You can try using the "Format Document" feature in
VSCode to help you indent the code. - Why terminated only some of the statements with a semicolon?
- Why use truncation instead of rounding to approximate the result to 1 decimal place?
Note: There are simpler ways (which involve using some built-in functions) to truncate/round a number to 1 decimal place.
Comment on lines
+8
to
18
| if(hours<1){ | ||
| return `12:${minutes} am` | ||
| } | ||
| if(hours==12 && minutes==00){ | ||
| return "12:00 pm" | ||
| } | ||
| if (hours > 12) { | ||
| return `${hours - 12}:00 pm`; | ||
| return `${hours - 12}:${minutes} pm`; | ||
| } | ||
| return `${time} am`; | ||
| } |
There was a problem hiding this comment.
-
Because
hourswon't be negative,if (hours == 0)would probably be more readable thanif (hours < 1). -
What is the 12-hour clock equivalent of 24-hour clock time "12:59"?
-
What do you expect from the following function calls? Are the return values formatted consistently?
formatAs12HourClock("01:33");
formatAs12HourClock("13:33");
cjyuan
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
In this pill request I have fixed errors, interpreted and implemented code
Questions