Glasgow | 25-ITP-SEP | Hanna Mykytiuk | Sprint 1 | coursework/sprint-1 #732

HannaOdud · 2025-10-05T18:30:50Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Briefly explain your PR.
All exercises of Sprint 1 are done.

Questions

Ask any questions you have for your reviewer.

github-actions · 2025-10-05T18:31:04Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-05T18:31:09Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-05T18:31:09Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-05T18:31:09Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-05T18:31:10Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-05T18:31:22Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-06T10:14:02Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

LonMcGregor

Good start on this sprint's tasks, I have spotted a few areas where you could improve answer further

LonMcGregor · 2025-10-06T10:14:20Z

Sprint-1/1-key-exercises/2-initials.js


-let initials = ``;
+    //let initials = `${firstName.charAt(0)}+${middleName.charAt(0)}+${lastName.charAt(0)}}`;
+    let initials = `${firstName.charAt(0)+middleName.charAt(0)+lastName.charAt(0)}`;


If you are concatenating values together, do you need the surrounding ${}?

No, we need them only when combining text with variables. I have removed them.

LonMcGregor · 2025-10-06T10:15:07Z

Sprint-1/2-mandatory-errors/4.js

-const 24hourClockTime = "08:53";
+const 24hourClockTime = "08:53";
+
+//Explenation: the name of value in  JS can not start with numbers.


Can you suggest some alternative names?

My variants:
twelveHourClockTime
twentyFourHourClockTime

LonMcGregor · 2025-10-06T10:15:46Z

Sprint-1/3-mandatory-interpret/2-time-format.js

+        // Mean the subtraction remaider(second)  from the total length (in second) and divide by 60, because we need Minutes (1 min = 60 sec)
 // e) What do you think the variable result represents? Can you think of a better name for this variable?
-
+        //time


Is it clear what the difference is between 'time' and movieLength? Could I understand the difference by quickly reading these two variable names?

I changed to more explicit name: "FormattedMovieTime".

github-actions · 2025-10-06T10:16:36Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-06T10:16:37Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-06T10:16:39Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-06T17:08:07Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-06T17:08:11Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-06T17:08:22Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

LonMcGregor

Great! This task looks complete now

github-actions · 2025-10-07T08:38:28Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-07T08:38:32Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Sprint 1 ia done.

eea88c3

HannaOdud added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 5, 2025

LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Oct 6, 2025

LonMcGregor reviewed Oct 6, 2025

View reviewed changes

Small changes according to review.

66fa83d

HannaOdud added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 6, 2025

LonMcGregor reviewed Oct 7, 2025

View reviewed changes

LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 7, 2025

Uh oh!

Glasgow | 25-ITP-SEP | Hanna Mykytiuk | Sprint 1 | coursework/sprint-1 #732

Are you sure you want to change the base?

Glasgow | 25-ITP-SEP | Hanna Mykytiuk | Sprint 1 | coursework/sprint-1 #732

Conversation

HannaOdud commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Questions

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 5, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

HannaOdud Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

HannaOdud Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

LonMcGregor Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

HannaOdud Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

github-actions bot commented Oct 6, 2025

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

github-actions bot commented Oct 7, 2025

Uh oh!

Uh oh!

HannaOdud commented Oct 5, 2025 •

edited

Loading