West Midlands | ITP-Sep-2025 | Ahmad Ehsas | Sprint 1 | Structuring and Testing Data #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

ahmadehsas wants to merge 17 commits into CodeYourFuture:main from ahmadehsas:coursework/sprint-1

ahmadehsas commented Oct 5, 2025 •

edited

Loading

Self checklist

I have committed my files one by one, on purpose, and for a reason
I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
I have tested my changes
My changes follow the style guide
My changes meet the requirements of this task

Changelist

I have completed all the mandatory tasks: key exercises, mandatory errors, and mandatory interpretation.

Questions

Ask any questions you have for your reviewer.

ahmadehsas added 17 commits

June 16, 2025 17:22


          Answered comment for count update in exercise -1

65fe894


          completed initials exercise using string indexing

c7a00b7


          Add dir and ext veriables to extract directory and extension from fil…

…e path.


          Add explanation of how num is calculated as a random number between m…

a9f60fe

…unimum and maximum.


          fixed error by changing const to let for age reasignment.

ac2cdb5


          Fixed reference error by declaring cityOfBirth before using it.


          fixed typeEroor by converting number to string before slicing last 4 …

…digits.


          Fixed syntax error by moving numbers after the words or spell the num…

…bers out, and fixed the format of the clock which was written incorrectly.


          Fixed syntax error in replaceAll for priceafteroneyear, and answer in…

bf8a890

…terpret exercise questions about function calls and variables.


          Added Answers to the questions about time conversion exercise. Added …

34c796a

…explanation for variable declaration, function calls, and expressions used in time conversion code.


          Added breakdown of code converting pence string to pound format.

b83f152


          completed chrome console exercise using prompt and alert

254cd3f


          investigate console object and dot notation in java script using chro…

7a97c4f

…me Devetools.


          Answered the question of line-9.

567e88f


          Replaced the word Const line to Const Variable on 9.

2f51f5b


           Answered the question on line 36 & 37.

838110d


          Answered the questio on line 23 & 24.

832af0e

github-actions bot commented Oct 5, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

ahmadehsas changed the title ~~West Midlands Coursework/sprint 1~~ West Midlands | ITP-Sep-2025 | Ahmad Ehsas | Sprint 1 | Structuring and Testing Data

github-actions bot commented Oct 5, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment

github-actions bot commented Oct 5, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

ahmadehsas added the Needs Review label

github-actions bot commented Oct 5, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

5 similar comments

github-actions bot commented Oct 5, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 5, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 5, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 5, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 5, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

LonMcGregor added the Review in progress label

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

LonMcGregor reviewed

View reviewed changes

LonMcGregor left a comment

This all looks good to me, well done

LonMcGregor added Complete and removed Needs Review Review in progress labels

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

2 similar comments

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions bot commented Oct 6, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels