Skip to content

Conversation

Baba05206
Copy link

@Baba05206 Baba05206 commented Oct 7, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have completed Sprint-1 tasks

Questions

Copy link

github-actions bot commented Oct 7, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Baba05206 Baba05206 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 7, 2025
Copy link

github-actions bot commented Oct 7, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
Copy link

github-actions bot commented Oct 7, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Baba05206 Baba05206 removed 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 7, 2025
Copy link

github-actions bot commented Oct 7, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
Copy link

github-actions bot commented Oct 7, 2025

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Baba05206 Baba05206 changed the title Coursework/sprint 1 Birmingham | 25-ITP-Sep | Baba Yusuf| Sprint 1 | Structuring-and-Testing Data Oct 7, 2025
Copy link

github-actions bot commented Oct 7, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Baba05206 Baba05206 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 7, 2025
Copy link

github-actions bot commented Oct 7, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
Copy link

github-actions bot commented Oct 7, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Baba05206
Copy link
Author

My initial submission was missing the PR title. I manually edited this in Github, I hope this is okay?
Birmingham | 25-ITP-Sep | Baba Yusuf| Sprint 1 | Structuring-and-Testing Data

Copy link

github-actions bot commented Oct 7, 2025

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Baba05206 Baba05206 changed the title Birmingham | 25-ITP-Sep | Baba Yusuf| Sprint 1 | Structuring-and-Testing Data Birmingham | 25-ITP-Sep | Baba Yusuf| Sprint 1 | Module-Structuring-and-Testing Data Oct 14, 2025
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@Baba05206 Baba05206 added the Module-Structuring-And-Testing-Data The name of the module. label Oct 14, 2025
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 15, 2025
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted a few areas where you could improve code further

Did you mean to make changes to the sprint 2 files? We try to keep pull requests specific to just the files in the feature we are changing - for this, everything within the sprint task directory.

// e) What do you think the variable result represents? Can you think of a better name for this variable?

// The variable result represents the formatted string that shows the movie length in hours, minutes, and seconds. A better name for this variable could be formattedMovieLength or movieDurationFormatted, as these names more clearly indicate that the variable contains a formatted representation of the movie's duration.
// f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an answer for this last question?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 15, 2025
@Baba05206 Baba05206 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 15, 2025
@LonMcGregor
Copy link

If you look here on github in the "files changed" section of this PR (tab at the top of the page), there are still some sprint 2 files left that shouldn't be here.

Also, could you address my above comment in file Sprint-1/3-mandatory-interpret/2-time-format.js

@LonMcGregor LonMcGregor removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 15, 2025
@Baba05206
Copy link
Author

Apologies for missing those again... i will be more careful during this review. I will revert shortly

@Baba05206
Copy link
Author

I have now made the required updates to my submitted tasks.

@Baba05206 Baba05206 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 19, 2025
@LonMcGregor
Copy link

Good work on the sprint tasks. They are finished now.

@LonMcGregor LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 20, 2025
@Baba05206
Copy link
Author

Muchas gracias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Structuring-And-Testing-Data The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants