Skip to content

Birmingham|25-ITP-SEP|Hadi Vahidi|Sprint 1|coursework/sprint-1 #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Birmingham|25-ITP-SEP|Hadi Vahidi|Sprint 1|coursework/sprint-1 #742

wants to merge 22 commits into from

Conversation

@HadiVahidi20
Copy link

@HadiVahidi20 HadiVahidi20 commented Oct 9, 2025

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I hove done all sprint one of module 2.

Questions

thank you very much

@HadiVahidi20
Add age calculation functionality and HTML structure for age input
1189fcd
@HadiVahidi20
Refactor age calculator layout and improve form structure
78b6a33
@HadiVahidi20
addWnetListener Example added
ea977e5
@HadiVahidi20
Refactor age calculator layout and improve form structure
22c0fee
@HadiVahidi20
percentage exersice added
c346f52
@HadiVahidi20
Enhance percentage exercise layout and add area calculation functiona…
ea0fca9 
…lity
@HadiVahidi20
Add area calculation alert to percentage exercise
5df448f
@HadiVahidi20
Add comments to clarify count variable increment logic
ef4f642
@HadiVahidi20
second exercise is done using charAt(index)
efa5aa8
@HadiVahidi20
Implement dir and ext variable assignments in file path exercise
aa951b4
@HadiVahidi20
Refactor random number generation logic and enhance comments for clar…
921ba5a 
…ity (exercise 4-random.js)
@HadiVahidi20
change the codes to comments in 0.js
e32fceb
@HadiVahidi20
mandatory-errors 2 is completed
3b87801
@HadiVahidi20
Fix variable initialization error by moving console.log after declara…
24ee904 
…tion in 2.js
@HadiVahidi20
Fix last4Digits assignment by converting cardNumber to string before …
d51395c 
…slicing
@HadiVahidi20
percentage exercise is completed
14e15a6
@HadiVahidi20
the movie length exercise is done
711385f
@HadiVahidi20
Update penceString value and enhance console logging for clarity in 3…
e82c680 
…-to-pounds.js
@HadiVahidi20
Enhance examples in objects.md to clarify console usage and output
b28011e
@HadiVahidi20
Implement to24hourtime function and add initial HTML test page
6c7a0b7
@HadiVahidi20 HadiVahidi20 added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 9, 2025
@LonMcGregor LonMcGregor added the Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. label Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

LonMcGregor
LonMcGregor reviewed Oct 15, 2025
View reviewed changes
Copy link

@LonMcGregor LonMcGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start on this sprint's tasks, I have spotted a few areas where you could improve answers further

Sprint-1/3-mandatory-interpret/1-percentage-change.js Outdated

// a) How many function calls are there in this file? Write down all the lines where a function call is made

/*There are four function calls in total: two in the line
Copy link

@LonMcGregor LonMcGregor Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure there are only 4?

Sprint-1/3-mandatory-interpret/2-time-format.js Outdated

// b) How many function calls are there?

/*There are no function calls in this code. Everything here is using operators and expressions, not calling functions.*/
Copy link

@LonMcGregor LonMcGregor Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure there are no functions? I think in both this and the previous task you are missing the same function call.

Copy link
Author

@HadiVahidi20 HadiVahidi20 Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, I forgot to count the console.log as a function call in both codes. thank you

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Oct 15, 2025
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

1 similar comment
@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Oct 15, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@HadiVahidi20 HadiVahidi20 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LonMcGregor LonMcGregor LonMcGregor left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@HadiVahidi20 @LonMcGregor