Skip to content

Add exercises for individual shell tools and shell pipelines #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 8, 2025

Conversation

illicitonion
Copy link
Member

@illicitonion illicitonion commented Nov 25, 2024

Achieving these exercises meets all of the shell tools learning objectives of the first two sprints.

Sample solutions can be seen in the HEAD commit of https://github.com/CodeYourFuture/Module-Tools/tree/individual-shell-tools-solutions (currently d827a5e)

@illicitonion illicitonion force-pushed the individual-shell-tools branch 4 times, most recently from 047b001 to be397fb Compare November 27, 2024 09:50
@illicitonion illicitonion changed the title Add exercises for individual shell tools Add exercises for individual shell tools and shell pipelines Nov 27, 2024
Copy link
Contributor

@40thieves 40thieves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only done the individual-shell-tools so far - since I wanted to get the feedback quicker and that's the only bit that's been merged on the curriculum - but it's looking good! Left a few comments about typos and minor suggestions.

illicitonion and others added 6 commits December 16, 2024 17:49
Co-authored-by: Alasdair Smith <alasdairsmith100@gmail.com>
Co-authored-by: Alasdair Smith <alasdairsmith100@gmail.com>
Co-authored-by: Alasdair Smith <alasdairsmith100@gmail.com>
Co-authored-by: Alasdair Smith <alasdairsmith100@gmail.com>
Co-authored-by: Alasdair Smith <alasdairsmith100@gmail.com>
Co-authored-by: Alasdair Smith <alasdairsmith100@gmail.com>
Copy link
Contributor

@40thieves 40thieves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: Oh wait, sorry I forgot about the other commands - will review those now.

Copy link
Contributor

@40thieves 40thieves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more comments/suggestions about the jq & shell-pipelines exercises, but looking pretty good!

illicitonion and others added 3 commits December 23, 2024 14:32
Co-authored-by: Alasdair Smith <alasdairsmith100@gmail.com>
Copy link
Contributor

@40thieves 40thieves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Apologies for the very long turnaround time!

@illicitonion illicitonion merged commit b4b77ec into main Jan 8, 2025
@illicitonion illicitonion deleted the individual-shell-tools branch January 8, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants