Skip to content

LONDON | DONARA BLANC | COWSAY PYTHON | SPRINT 4 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

donarbl
Copy link

@donarbl donarbl commented May 2, 2025

Learners, PR Template

Self checklist

  • [ X] I have committed my files one by one, on purpose, and for a reason
  • [ X] I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
  • [ x] I have tested my changes
  • [ X] My changes follow the style guide
  • [ X] My changes meet the requirements of this task

Changelist

I used the prep materials to create a python virtual environment, and I had trouble deciding where the venv should go in the root folder or the folder where the cowsay is implemented. Quite enjoyed as well seeing animals and making them with messages.

Questions

Ask any questions you have for your reviewer.

@donarbl donarbl added Needs Review Participant to add when requesting review 📅 Sprint 4 Assigned during Sprint 4 of this module labels May 2, 2025
@OracPrime OracPrime added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Participant to add when requesting review labels May 26, 2025
Copy link

@OracPrime OracPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mark as "Needs Review" again when you have addressed my comment

@@ -0,0 +1,26 @@
import cowsay

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I were to check out this code, how would python find cowsay? What has been covered in the course about adding libraries to your code? Is there another file you need to edit or add?

The rest of your code is fine - so the contents of cow.py - but you are missing a vital element to make the whole thing work.

@OracPrime OracPrime added Reviewed Volunteer to add when completing a review and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewed Volunteer to add when completing a review 📅 Sprint 4 Assigned during Sprint 4 of this module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants