ITP May 25 | Houssam Lahlah | CodewarsAPI/Project #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added <codewars-badge> and <codewars-top-languages> components with fetch from API. - Fix username encoding to handle spaces in Codewars username. - Update badge component to display totalCompleted instead of undefined totalScore.
✅ Deploy Preview for cyf-codewars-projects ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
## Changelist
Changes include:
component showing:
component showing top 3 languages and their ranks
Fixed issue with username containing spaces by using encodeURIComponent
Fixed undefined totalScore by using totalCompleted challenges
Web components are reusable custom HTML elements that allow us to modularly display Codewars data.
This keeps the code clean and easy to maintain.
Tested in browser: components display correctly and fetch data from the API.
## Questions
This PR adds two web components to display Codewars data for my account "Houssam LH".