Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JS3 Week 2 prep content MOVED TO SPRINT 3 #403

Merged
merged 18 commits into from
Dec 27, 2023
Merged

Add JS3 Week 2 prep content MOVED TO SPRINT 3 #403

merged 18 commits into from
Dec 27, 2023

Conversation

Dedekind561
Copy link
Contributor

What does this change?

Module:
Week(s):

Checklist

Description

Who needs to know about this?

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for cyf-curriculum ready!

Name Link
🔨 Latest commit 5d0adb3
🔍 Latest deploy log https://app.netlify.com/sites/cyf-curriculum/deploys/658beffcb3bf3600088b8a1b
😎 Deploy Preview https://deploy-preview-403--cyf-curriculum.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 91 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Dedekind561 Dedekind561 changed the title save work in progress Add JS3 Week 2 prep content Nov 28, 2023
@SallyMcGrath
Copy link
Member

Thanks! I'll take it from here @Dedekind561 . Hands off the keyboard! See you tomorrow!

@SallyMcGrath SallyMcGrath added this to the JS3 milestone Nov 28, 2023
@SallyMcGrath SallyMcGrath self-assigned this Nov 28, 2023
I think that's all we can reasonably do. I feel overloaded just writing it.

Next week we can do sequencing, async/await etc
@SallyMcGrath SallyMcGrath changed the title Add JS3 Week 2 prep content Add JS3 Week 2 prep content MOVED TO SPRINT 3 Nov 30, 2023
@SallyMcGrath
Copy link
Member

OK so

I've reordered it and split it into two pieces as per #315

This week considers asynchronous execution in a single threaded language.

⚠️ It skims over the difference between the callback queue and the microtask queue! I don't think they need this nuance now.
⚠️ It introduces async await syntax before explaining it! I think all the syntax can go into next week and as per Daniel's suggestion in 2021 I will lean heavily into async/await and skim chaining and Promises lore

I have drawn a crazy map. I actually find sketching like this amazingly helpful and I know some trainees do too. But I have hidden the large ones behind details blocks as I don't want to break people.

If you would like to improve this map, I recommend this live editor for Mermaid

@SallyMcGrath SallyMcGrath marked this pull request as ready for review November 30, 2023 21:18
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good - I opened up #462 with some copy edits.

I'm not sure I'm sold on the "using promises without explaining promises at all" part... I'd maybe be tempted to remove the .then and "console.log a promise and look at it" piece, and just give the replacement code and say "We'll learn more about how it works next sprint"... WDYT?

1. update time of async
2. move blocks into en
3. clarify web api def
4. bold latency
5. clarify concept list
6. rm unused blocks
it should be a web component
skip straight to film fetch
autocomplete strikes again
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except both the mermaid and the loupe embeds seem broken?

Screenshot 2023-12-26 at 22 39 33 Screenshot 2023-12-26 at 22 40 01

the ultimate fix for this will clearly be to write some kind of mutation observer in here
@SallyMcGrath SallyMcGrath merged commit fbce9cf into main Dec 27, 2023
@SallyMcGrath SallyMcGrath deleted the js3/week-2 branch December 27, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants