Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unified auth experience for Volunteer signup/login[Staging] #167

Open
wants to merge 54 commits into
base: staging
Choose a base branch
from
Open

Unified auth experience for Volunteer signup/login[Staging] #167

wants to merge 54 commits into from

Conversation

ChidimmaOfodum
Copy link
Contributor

@ChidimmaOfodum ChidimmaOfodum commented Aug 5, 2024 •
edited
Loading

This is a:

  • ✨ New feature - new behaviour has been implemented
  • 🐛 Bug fix - existing behaviour has been made to behave
  • ♻️ Refactor - the behaviour has not changed, just the implementation
  • ✅ Test backfill - tests for existing behaviour were added but the behaviour itself hasn't changed
  • ⚙️ Chore - maintenance task, behaviour and implementation haven't changed

Description

  • Purpose -
  • Currently, the users (applicants and volunteers) have different accounts in the Dashboard. This PR is too unify the auth experience for volunteer login and signup.
  • How to check -
  • Signup as a volunteer using the new signup/login page
  • Complete the form to save your applicantion.
  • Same email can be used to login into application-process.
  • Reverse the process starting with application process -> volunteer

Links

  • CodeYourFuture/tech-team#828

Author checklist

  • I have written a title that reflects the relevant ticket
  • I have written a description that says what the PR does and how to validate it
  • I have linked to the project board ticket (and any related PRs/issues) in the Links section
  • I have added a link to this PR to the ticket
  • I have made the PR to qa from a branch named <category>/<name>, e.g. feature/edit-spaceships or bugfix/restore-oxygen
  • I have completed the manual tests described here
  • I have requested reviewers here and in my team chat channel
  • I have spoken with my PM or TL about any parts of this task that may have become out-of-scope, or any additional improvements that I now realise may benefit my project
  • I have added tests, or new tests were not required
  • I have updated any documentation (e.g. diagrams, schemas), or documentation updates were not required

khmdagal and others added 30 commits September 21, 2023 09:59
@khmdagal
Merge pull request #139 from CodeYourFuture/feature-765-add-iam-not-s…
6a5444a 
…ure-option-to-the-volunteer-teams-question

Add "I am not sure" option in the drop-down menu in the volunteer form if a new volunteer not sure which team to join
@AL-ASHMALI
Merge pull request #130 from CodeYourFuture/dependabot/npm_and_yarn/w…
f62249b 
…ord-wrap-1.2.4

Bump word-wrap from 1.2.3 to 1.2.4
@khmdagal
Create fetch fucntion to get employers data from the database
9187734
@khmdagal
Remove hard coded employers array
a641c80
@khmdagal
Create a POST request to post new employer name to the database and s…
5afb787 
…ort employers alphabetically
@khmdagal
Add mock postNewEmployer function
ec272aa
@khmdagal
Remove code that adding new employer name to the database
b70e0a9
@khmdagal
Create sample employer data in e2e/fixture file and updated journey t…
1b7591e 
…est file to get the correct employer id
@AL-ASHMALI
Merge pull request #151 from CodeYourFuture/feature-create-a-DB-of-em…
3bdcc1e 
…ployer-names-for-volunteer-form

feature-create-a-DB-collection(table)-for-employer-names-for-volunteer-form[QA]
@khmdagal
Edit variable names
1177ae3
@khmdagal
Assert correct employer name so test to pass
d9205f3
@khmdagal
Revert all changes that were merged to the qa
5003ef5
@khmdagal
Replace Capgemini to original code Cap
9cc7d3c
@ChidimmaOfodum
Merge pull request #153 from CodeYourFuture/feature/697-move-employer…
5a45596 
…-names-to-backend-code

Feature/697-move-employer-names-to-backend-code-rever-all-changes-merged-to-qa-branch[QA]
@khmdagal
Merge pull request #154 from CodeYourFuture/feature/697-move-employer…
7417398 
…-names-to-backend-code-reduced-scope

Feature/697-move-employer-names-to-backend-code[QA]
@CanaryWharf
Merge pull request #156 from CodeYourFuture/bump-babel-traverse-to-7.…
b542351 
…23.2

[QA] Bump babel traverse to 7.23.2
@josamit
Unified auth experience for Volunteer signup/login
0257b0c
@josamit
Unified auth experience for Volunteer signup/login
f79efb7
@josamit
Unified auth experience for Volunteer signup/login
2443baf
@josamit
Unified auth experience for Volunteer signup/login
2b0851e
@josamit
Unified auth experience for Volunteer signup/login
1d74d9b
@ChidimmaOfodum
error msg displayed
04b9109
@ChidimmaOfodum
updating e2e tests
d606604
@ChidimmaOfodum
updating lock file
aa69cde
@ChidimmaOfodum
path to private key from working dir
82ad517
@ChidimmaOfodum
path to private key from working dir
5604ce7
@ChidimmaOfodum
path to private key from working dir
dfa1116
@ChidimmaOfodum
flake free test
5a07c6a
@ChidimmaOfodum
change class to functional component
e60a74e
@ChidimmaOfodum
reusable icon component
bf0ff19
ChidimmaOfodum and others added 19 commits July 19, 2024 02:45
@ChidimmaOfodum
node-engine revert
625ad00
@ChidimmaOfodum
adding login in beforeEach
d05836e
@ChidimmaOfodum
Delete e2e/privatekey
2c4fade
@ChidimmaOfodum
Merge pull request #164 from josamit/cyf-twlo
530d9a3 
Unified auth experience for Volunteer signup/login
@josamit @ChidimmaOfodum
Unified auth experience for Volunteer signup/login
11bb6c8
@josamit @ChidimmaOfodum
Unified auth experience for Volunteer signup/login
c665c2b
@josamit @ChidimmaOfodum
Unified auth experience for Volunteer signup/login
475d4ed
@josamit @ChidimmaOfodum
Unified auth experience for Volunteer signup/login
dedf18b
@josamit @ChidimmaOfodum
Unified auth experience for Volunteer signup/login
ea46975
@ChidimmaOfodum
error msg displayed
7e2ed53
@ChidimmaOfodum
updating e2e tests
b61d627
@ChidimmaOfodum
updating lock file
5ec722a
@ChidimmaOfodum
path to private key from working dir
f5e5cb8
@ChidimmaOfodum
flake free test
9ecdfed
@ChidimmaOfodum
change class to functional component
278526c
@ChidimmaOfodum
reusable icon component
a838fd4
@ChidimmaOfodum
node-engine revert
065a5b3
@ChidimmaOfodum
adding login in beforeEach
ee4acea
@ChidimmaOfodum
rebase changes
fa165a0
@ChidimmaOfodum ChidimmaOfodum changed the title Cyf twlo Unified auth experience for Volunteer signup/login[Staging] Aug 5, 2024
@ChidimmaOfodum ChidimmaOfodum requested a review from enderta August 5, 2024 12:05
enderta
enderta approved these changes Aug 7, 2024 •
edited
Loading
View reviewed changes
@enderta enderta self-requested a review August 7, 2024 12:12
enderta
enderta approved these changes Sep 3, 2024
View reviewed changes
Copy link

@enderta enderta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enderta enderta enderta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ChidimmaOfodum @enderta @khmdagal @AL-ASHMALI @CanaryWharf @josamit