Make AccuREST tasks cacheable #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make tasks cacheable.
OlgaMaciaszek
approved these changes
Jul 13, 2017
| @@ -183,6 +183,7 @@ class WireMockGroovyDslSpec extends Specification implements WireMockStubVerifie | |||
| when: | |||
| String wireMockStub = new WireMockStubStrategy("Test", new Contract(null, false, 0, null), groovyDsl).toWireMockClientStub() | |||
| then: | |||
| //TODO: That assertion fails on some environments due to 2 ways how body array is created - with 'created' at the beginning or 'id' | |||
There was a problem hiding this comment.
Maybe instead of adding a comment this assertion could be modified to compare the jsons wtih problematic elements removed on both sides?
There was a problem hiding this comment.
This project is no longer actively maintained :(
| testCompile("com.github.tomakehurst:wiremock:$wiremockVersion") { | ||
| exclude group: 'org.eclipse.jetty' | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe remove unnecessary spacing?
There was a problem hiding this comment.
What do you exactly mean? :)
There was a problem hiding this comment.
Sorry. I meant the additional unnecessary line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AccuREST tasks are cacheable. To do that a hack to provide distinct configuration with not overlapping outputs has to be used.
To be able to use
@CacheableTaskannotation project had to be upgraded to Gradle 3 which in turn requires newer Spring Boot (which was painful...).