Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

92 animations and infomessages #93

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Conversation

szv
Copy link
Collaborator

@szv szv commented Dec 19, 2023

No description provided.

@szv szv linked an issue Dec 19, 2023 that may be closed by this pull request
@szv szv requested a review from christiannagel December 19, 2023 15:11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should have a unit test

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit test for the view-models.
The view-models library should also have a separate pull request - we have releases https://github.com/CodebreakerApp/Codebreaker.Xaml/releases, and the pull requests miss linked issues. Commits should have a linked issue.

Copy link
Contributor

@christiannagel christiannagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments for updates and next updates

@christiannagel christiannagel merged commit e273d26 into main Dec 19, 2023
@christiannagel christiannagel deleted the 92-animations-and-infomessages branch December 19, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animations and InfoMessages
2 participants