Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Utility Types in Typescript #5093

Merged
merged 70 commits into from
Oct 20, 2024

Conversation

Mandipbhattarai
Copy link
Contributor

@Mandipbhattarai Mandipbhattarai commented Aug 23, 2024

Description

Issue Solved

Fixes #5091

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@Mandipbhattarai Mandipbhattarai changed the title Added Utility Types in Typescript Added Utility Types in Typescript | Fixes #5091 Aug 23, 2024
@Mandipbhattarai Mandipbhattarai changed the title Added Utility Types in Typescript | Fixes #5091 Added Utility Types in Typescript Aug 23, 2024
@dakshdeepHERE dakshdeepHERE self-assigned this Aug 23, 2024
@dakshdeepHERE dakshdeepHERE added typescript TypeScript entries new entry New entry or entries status: under review Issue or PR is currently being reviewed labels Aug 23, 2024
Copy link
Collaborator

@dakshdeepHERE dakshdeepHERE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am requesting some changes from you side please make them and tag me once u are done. Also please use the pseudo tag for evey syntax snippets in the entry. Thank you for the contribution. :)

Subjects:
- 'Web Development'
Tags:
- 'Utility Types'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag doesnt exist here, please add this in the tags.md file.

content/typescript/concepts/utility-types/utility-types.md Outdated Show resolved Hide resolved

A partial is written as:

```ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use pseudo tag for syntax please

content/typescript/concepts/utility-types/utility-types.md Outdated Show resolved Hide resolved
content/typescript/concepts/utility-types/utility-types.md Outdated Show resolved Hide resolved
content/typescript/concepts/utility-types/utility-types.md Outdated Show resolved Hide resolved
content/typescript/concepts/utility-types/utility-types.md Outdated Show resolved Hide resolved

Readonly is written as:

```ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use pseudo tag for syntax everywhere please.


Pick is written as:

```ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pseudo tag please


Omit is written as:

```ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pseudo tag

@dakshdeepHERE dakshdeepHERE added help wanted Extra attention is needed status: review 1️⃣ completed status: waiting for author and removed help wanted Extra attention is needed status: under review Issue or PR is currently being reviewed labels Aug 23, 2024
Mandipbhattarai and others added 12 commits August 24, 2024 00:26
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
@Mandipbhattarai
Copy link
Contributor Author

I have applied the changes. Can you review it @dakshdeepHERE?

Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mandipbhattarai
I have suggested a few changes please make them and let me know. Also I want you to include the stage 'Utility types' in the tags.md file.

Mandipbhattarai and others added 8 commits October 12, 2024 17:10
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
@Mandipbhattarai
Copy link
Contributor Author

@SaviDahegaonkar as per your changes i have updated it and also included the utility types.

@SaviDahegaonkar
Copy link
Collaborator

Hey @Mandipbhattarai ,
I can't find the tag 'utility types' in the tags.md list, please add one.

Thanks,
Savi

@Mandipbhattarai
Copy link
Contributor Author

Mandipbhattarai commented Oct 15, 2024

Can you recheck it @SaviDahegaonkar because I had already added the tag.

@SaviDahegaonkar
Copy link
Collaborator

Hey @Mandipbhattarai , Are you sure you added the tag in the tags.md list for the forked repository because as you can see I can't find any 'utility types' tag .
Screenshot 2024-10-15 165524

@Mandipbhattarai
Copy link
Contributor Author

@SaviDahegaonkar can you check the file changed because it shows the addition of 'Utility Types' in the tags.md from my pr.
image

@SaviDahegaonkar
Copy link
Collaborator

@SaviDahegaonkar can you check the file changed because it shows the addition of 'Utility Types' in the tags.md from my pr. image

Yeah I got it, it was a network issue from my end so I was unable to find the reflected changes.

Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mandipbhattarai ,
The entry LGTM!

Thanks,
Savi

@Mandipbhattarai
Copy link
Contributor Author

@SaviDahegaonkar is there any changes to be done?

@SaviDahegaonkar
Copy link
Collaborator

@SaviDahegaonkar is there any changes to be done?

Nope, I will merge this PR.

@SaviDahegaonkar SaviDahegaonkar merged commit c590425 into Codecademy:main Oct 20, 2024
6 checks passed
Copy link

👋 @Mandipbhattarai
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/typescript/utility-types
https://github.com/Codecademy/docs/blob/main/documentation/tags.md

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new entry New entry or entries status: review 1️⃣ completed status: under review Issue or PR is currently being reviewed typescript TypeScript entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Entry] Subject: Entry Add Utility Types to Typescript
3 participants