-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Utility Types in Typescript #5093
Added Utility Types in Typescript #5093
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am requesting some changes from you side please make them and tag me once u are done. Also please use the pseudo
tag for evey syntax snippets in the entry. Thank you for the contribution. :)
Subjects: | ||
- 'Web Development' | ||
Tags: | ||
- 'Utility Types' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tag doesnt exist here, please add this in the tags.md file.
|
||
A partial is written as: | ||
|
||
```ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use pseudo tag for syntax please
|
||
Readonly is written as: | ||
|
||
```ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use pseudo
tag for syntax everywhere please.
|
||
Pick is written as: | ||
|
||
```ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pseudo tag please
|
||
Omit is written as: | ||
|
||
```ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pseudo tag
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
Co-authored-by: Daksha Deep <dakshadeep1234@gmail.com>
I have applied the changes. Can you review it @dakshdeepHERE? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Mandipbhattarai
I have suggested a few changes please make them and let me know. Also I want you to include the stage 'Utility types' in the tags.md file.
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
@SaviDahegaonkar as per your changes i have updated it and also included the utility types. |
Hey @Mandipbhattarai , Thanks, |
Can you recheck it @SaviDahegaonkar because I had already added the tag. |
Hey @Mandipbhattarai , Are you sure you added the tag in the tags.md list for the forked repository because as you can see I can't find any 'utility types' tag . |
@SaviDahegaonkar can you check the file changed because it shows the addition of 'Utility Types' in the tags.md from my pr. |
Yeah I got it, it was a network issue from my end so I was unable to find the reflected changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Mandipbhattarai ,
The entry LGTM!
Thanks,
Savi
@SaviDahegaonkar is there any changes to be done? |
Nope, I will merge this PR. |
👋 @Mandipbhattarai 🎉 Your contribution(s) can be seen here: https://www.codecademy.com/resources/docs/typescript/utility-types Please note it may take a little while for changes to become visible. |
Description
Issue Solved
Fixes #5091
Type of Change
Checklist
main
branch.Issues Solved
section.