Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add concept entry for postgresql transactions #5552

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

add concept entry for postgresql transactions #5552

wants to merge 15 commits into from

Conversation

christina-ml
Copy link
Contributor

Description

Add New Concept Entry for PostgreSQL Transactions.

Issue Solved

Closes #4647

Type of Change

  • Adding a new entry
  • Editing an existing entry (fixing a typo, bug, issues, etc)
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@cigar-galaxy82 cigar-galaxy82 self-assigned this Oct 23, 2024
@Radhika-okhade Radhika-okhade self-assigned this Nov 4, 2024
@Radhika-okhade Radhika-okhade added new entry New entry or entries claimed Issue is claimed and closed to further assignment status: under review Issue or PR is currently being reviewed postgresql PostgreSQL good first issue Good for newcomers labels Nov 4, 2024
@Radhika-okhade
Copy link
Collaborator

Hey @christina-ml thank you for contributing to Codecademy Docs! The entry is very well written! 😄

I've suggested some minor changes, could you please review and modify those at your earliest convenience? Thank you! 😃

@Radhika-okhade Radhika-okhade added status: review 1️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Nov 4, 2024
@christina-ml
Copy link
Contributor Author

christina-ml commented Nov 4, 2024 •
edited
Loading

Hey @Radhika-okhade thank you! I modified the file with the changes based on your suggestions, and adding the outputs to the examples.

I tried changing the code blocks to use pseudo, but it did not highlight the SQL syntax correctly, so I reverted it back to sql.

@Radhika-okhade
Copy link
Collaborator

Hey! @christina-ml Can you please output for both Example 1 and Example 2.

@christina-ml
Copy link
Contributor Author

christina-ml commented Nov 6, 2024 •
edited
Loading

Hey @Radhika-okhade! I have updated the file to clarify the outputs for Example 1 and Example 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radhika-okhade Radhika-okhade Radhika-okhade approved these changes

Assignees

@Radhika-okhade Radhika-okhade

Labels
claimed Issue is claimed and closed to further assignment good first issue Good for newcomers new entry New entry or entries postgresql PostgreSQL status: ready for next review status: review 1️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Concept Entry] Postgresql transactions
4 participants
@christina-ml @Radhika-okhade @mamtawardhani @cigar-galaxy82