Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#5867 : ConceptEntry] Pytorch: HandlingBatches (docs) #5921

Merged
merged 14 commits into from
Jan 18, 2025
Merged

[#5867 : ConceptEntry] Pytorch: HandlingBatches (docs) #5921

merged 14 commits into from
Jan 18, 2025
+107 −0

Conversation

Swordfish189
Copy link
Contributor

@Swordfish189 Swordfish189 commented Jan 6, 2025 •
edited
Loading

Description

Added the "Pytorch: Handling Batches" concept as a new entry, via the file docs/content/pytorch/concepts/handling-batches/handling-batches.md

Issue Solved

Closes #5867

Type of Change

  • Adding a new entry

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Swordfish189 Swordfish189 marked this pull request as ready for review January 6, 2025 13:28
@Swordfish189 Swordfish189 mentioned this pull request Jan 6, 2025
Closed
3 tasks
@avdhoottt avdhoottt self-assigned this Jan 6, 2025
@avdhoottt avdhoottt added new entry New entry or entries status: under review Issue or PR is currently being reviewed pytorch PyTorch labels Jan 6, 2025
avdhoottt
avdhoottt requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@avdhoottt avdhoottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I suggested some changes in the entry. Please make them as soon as possible. Thank you!!

content/pytorch/concepts/handling-batches/handling-batches.md Outdated Show resolved Hide resolved
content/pytorch/concepts/handling-batches/handling-batches.md Outdated Show resolved Hide resolved
content/pytorch/concepts/handling-batches/handling-batches.md Outdated Show resolved Hide resolved
content/pytorch/concepts/handling-batches/handling-batches.md Outdated Show resolved Hide resolved
content/pytorch/concepts/handling-batches/handling-batches.md Outdated Show resolved Hide resolved
content/pytorch/concepts/handling-batches/handling-batches.md Outdated Show resolved Hide resolved
content/pytorch/concepts/handling-batches/handling-batches.md Outdated Show resolved Hide resolved
content/pytorch/concepts/handling-batches/handling-batches.md Outdated Show resolved Hide resolved
content/pytorch/concepts/handling-batches/handling-batches.md Outdated Show resolved Hide resolved
@Swordfish189 Swordfish189 force-pushed the pytorch-handling-batches branch from b24b107 to 4367cdc Compare January 9, 2025 16:55
@Swordfish189
Copy link
Contributor Author

Linked an unrelated Issue by mistake so I force pushed to correct the mistake.
Otherwise addressed the requested changes, so should be ready for the next review. :)
Thanks in advance!

@avdhoottt
Copy link
Collaborator

Hey @Swordfish189, thanks for making the changes. This PR is ready for the second review!!

@Sriparno08 Sriparno08 self-assigned this Jan 13, 2025
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jan 13, 2025
Sriparno08
Sriparno08 approved these changes Jan 18, 2025
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @Swordfish189!

@Sriparno08 Sriparno08 merged commit b672b38 into Codecademy:main Jan 18, 2025
7 checks passed
@github-actions GitHub Actions
Copy link

👋 @Swordfish189
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/pytorch/handling-batches

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, visit the linked accounts page and ensure that your GitHub account is linked.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriparno08 Sriparno08 Sriparno08 approved these changes

@avdhoottt avdhoottt avdhoottt approved these changes

Assignees

@avdhoottt avdhoottt

@Sriparno08 Sriparno08

Labels
new entry New entry or entries pytorch PyTorch status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Concept Entry] PyTorch: Handling Batches  
4 participants
@Swordfish189 @CLAassistant @avdhoottt @Sriparno08