Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ids using snort #59

Closed
wants to merge 1 commit into from
Closed

ids using snort #59

wants to merge 1 commit into from

Conversation

SimranLahrani842
Copy link

fixes issue #58
entire steps are explained in detail and are implemented by myself. Just follow the steps to achieve ids Using snort!!
It can be done in Windows and ubuntu.
I have mentioned steps in window.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Simran seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@SimranLahrani842
Copy link
Author

please review my pr @KTom101 , @yangc95 and @SSwiniarski

@KTom101 KTom101 added the invalid This doesn't seem right label Jun 27, 2023
@KTom101 KTom101 self-assigned this Jun 27, 2023
@KTom101 KTom101 added the status: under review Issue or PR is currently being reviewed label Jun 27, 2023
@KTom101
Copy link
Collaborator

KTom101 commented Jun 27, 2023

@SimranLahrani842 Thank you for your submission. There are a few things that need to be addressed.

First, the metadata that should be at the top of the file is missing. Please look in the documentation folder to see the mockups of how the metadata should look. You can do this by viewing the raw files.

Secondly, when viewing the file, the structure is very unclear without the use of line breaks and spacing. Particularly in the step-by-step instructions shown in the image below:

Screenshot 2023-06-27 at 5 09 09 PM

Third, for writing a tutorial like this, it is important to add images so the reader can have a better idea of what's going on. If you're having trouble understanding what we're looking for in UGC content, please take a look at some other UGC content like the ones listed here. You can also look in the content folder to view the raw files.

@KTom101 KTom101 removed the status: under review Issue or PR is currently being reviewed label Jun 27, 2023
@SimranLahrani842
Copy link
Author

@SimranLahrani842 Thank you for your submission. There are a few things that need to be addressed.

First, the metadata that should be at the top of the file is missing. Please look in the documentation folder to see the mockups of how the metadata should look. You can do this by viewing the raw files.

Secondly, when viewing the file, the structure is very unclear without the use of line breaks and spacing. Particularly in the step-by-step instructions shown in the image below:

Screenshot 2023-06-27 at 5 09 09 PM Third, for writing a tutorial like this, it is important to add images so the reader can have a better idea of what's going on. If you're having trouble understanding what we're looking for in UGC content, please take a look at some other UGC content like the ones listed [here](https://github.com/Codecademy/ugc#what-are-community-articles). You can also look in the [content folder](https://github.com/Codecademy/ugc/tree/main/content) to view the raw files.

Got it mam I ll do the required changes.

@yangc95
Copy link
Collaborator

yangc95 commented Sep 11, 2023

Just checking in @SimranLahrani842 are you still working on this?

@KTom101
Copy link
Collaborator

KTom101 commented Nov 9, 2023

@SimranLahrani842 Closing this out due to inactivity.

@KTom101 KTom101 closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants