Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staff page updates #125

Closed
wants to merge 2 commits into from
Closed

Conversation

lyallstewart
Copy link
Member

@lyallstewart lyallstewart commented Aug 1, 2022

What issue is this solving?

Closes #115

Description

  • Updates the staff list to reflect current staff.
  • Overhauls how profile pictures are stored, moving them all to local images imported into a JS object.

Any helpful knowledge/context for the reviewer?

  • Any new dependencies to install? ❌
  • Any special requirements to test? ❌

Feelings gif (optional)

What gif best describes your feeling working on this issue?
A keyboard with a moving copy-paste button

Please make sure you've attempted to meet the following coding standards

  • Code has been tested and does not produce errors
  • Code is readable and formatted
  • There isn't any unnecessary commented-out code

@lyallstewart lyallstewart requested a review from a team August 1, 2022 17:24
Copy link
Contributor

@mikejoh12 mikejoh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I wonder if we can't make Staff.jsx a bit more DRY at the same time in this PR by replacing the name, pfp, and bio props with just a user prop that is passed to the StaffCard component where it can be destructured. So we could use:

              <StaffCard
                key={user['name']}
                user={user}
                role="super-admin"
              />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix how profile pictures are stored
2 participants