fix verifyNeverInvoked with array params #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitpick-CI
reviewed
Jan 6, 2017
tests/unit/VerifierTest.php
Outdated
|
|
||
| public function testverifyWithMutliplesParams() | ||
| { | ||
| $this->specify('works for instance proxy', function() { |
There was a problem hiding this comment.
Expected 1 space after FUNCTION keyword; 0 found
Nitpick-CI
reviewed
Jan 6, 2017
tests/unit/VerifierTest.php
Outdated
| $user->setNameAndInfo("Bob Jones", "Infos"); | ||
|
|
||
| // verify | ||
| $user->verifyInvoked('setNameAndInfo',["Bob Jones", "Infos"]); |
There was a problem hiding this comment.
No space found after comma in function call
Nitpick-CI
reviewed
Jan 6, 2017
tests/unit/VerifierTest.php
Outdated
| $user->verifyNeverInvoked('setNameAndInfo', ["Bob Jones", "Infos"]); | ||
| // If i dont fail, my test fail | ||
| throw new fail('verifyNeverInvoked'); | ||
| } catch (\Exception $e) {} |
There was a problem hiding this comment.
- Expected 1 newline after opening brace; 0 found
- Closing brace must be on a line by itself
Nitpick-CI
reviewed
Jan 6, 2017
| $user->verifyNeverInvoked('setName', "Bob Jones"); | ||
| // If i dont fail, my test fail | ||
| throw new fail('verifyNeverInvoked'); | ||
| } catch (\Exception $e) {} |
There was a problem hiding this comment.
- Expected 1 newline after opening brace; 0 found
- Closing brace must be on a line by itself
Nitpick-CI
reviewed
Jan 6, 2017
| $user->verifyNeverInvoked('setNameAndInfo', ["Bob Jones", "Infos"]); | ||
| // If i dont fail, my test fail | ||
| throw new fail('verifyNeverInvoked'); | ||
| } catch (\Exception $e) { |
There was a problem hiding this comment.
Expected 1 newline after opening brace; 2 found
louvelmathieu
changed the title
sergeyklay
approved these changes
Jan 31, 2017
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for verifyNeverInvoked when you use it with array (for function with multiple params)
Before the fix, something like this worked :