Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AdvancedUsage.md #870

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update AdvancedUsage.md #870

wants to merge 1 commit into from

Conversation

GlebkaF
Copy link
Contributor

@GlebkaF GlebkaF commented Sep 16, 2024 •
edited
Loading

If used as described in the current documentation, codeception throws an error

In Step.php line 44:
                                                                               
  Codeception\Step::__construct(): Argument #2 ($arguments) must be of type a  
  rray, string given, called in /opt/app/vendor/codeception/codeception/src/C  
  odeception/Test/Cest.php on line 89

But it would be great if it could work without additional parentheses.

Arhell
Arhell reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Naktibalda
Please take a look when you have time, thanks

@W0rma W0rma mentioned this pull request Dec 5, 2024
Open
@W0rma
Copy link

W0rma commented Dec 5, 2024

This PR can be closed if Codeception/Codeception#6812 is accepted because it adjusts the implementation to the documented behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GlebkaF @W0rma @Arhell