Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue having null values in database because of string type #65

Closed
guraurobi opened this issue Dec 13, 2023 · 2 comments
Closed

Issue having null values in database because of string type #65

guraurobi opened this issue Dec 13, 2023 · 2 comments

Comments

@guraurobi
Copy link

guraurobi commented Dec 13, 2023

protected function isBinary(string $string): bool

This new addition broke all usages of haveInDatabase of null data for a certain column.

Example of fail:
$I->haveInDatabase('table_name', ['column_name' => null]);

Results in:

[TypeError] Codeception\Lib\Driver\Db::isBinary(): Argument #1 ($string) must be of type string, null given, called in /app/vendor/codeception/module-db/src/Codeception/Lib/Driver/Db.php on line 297

@troy-rudolph
Copy link

Please merge #63. The fix is there.

@guraurobi
Copy link
Author

Hey @troy-rudolph! Thanks so much for this fast fix, but please check my comments, might be useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants