Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MSSQL startup #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iliayatsenko
Copy link

Closes #74

@@ -5,7 +5,7 @@

for i in {1..50};
do
/opt/mssql-tools/bin/sqlcmd -S localhost -U sa -P $SA_PASSWORD -d master -Q "CREATE DATABASE $MSSQL_DATABASE;"
/opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P $SA_PASSWORD -No -d master -Q "CREATE DATABASE $MSSQL_DATABASE;"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iliayatsenko Do you have some reference about this renaming?

Could this be the reason for the failing pipeline in #77 (comment) as well?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@W0rma , yes, all description is in related issue. In short, please see this comment - microsoft/mssql-docker#892 (comment)

Regarding #77 , yes, it looks like the reason is the same.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest replacing the MSSQL image with server:2022-CU13-ubuntu-20.04, as the path issue is fixed in this version. This change will help avoid breaking the CI again if they revert the path in the future.

You can replace the image in docker_compose.yaml and github action configuration.

I've tested it on my branch and local machine, and it works properly.

@W0rma W0rma mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local tests fail with error during connection to MSSQL
4 participants