Skip to content

Fixing @param for loadFixtures() #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixing @param for loadFixtures() #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Codeception/Module/Doctrine.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ private function extractPrimaryKey(object $instance)
*
* This method requires [`doctrine/data-fixtures`](https://github.com/doctrine/data-fixtures) to be installed.
*
* @param class-string<FixtureInterface>|class-string<FixtureInterface>[]|list<FixtureInterface> $fixtures
* @param class-string<\Doctrine\Common\DataFixtures\FixtureInterface>|class-string<\Doctrine\Common\DataFixtures\FixtureInterface>[]|list<\Doctrine\Common\DataFixtures\FixtureInterface> $fixtures
Copy link
Contributor

@W0rma W0rma Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThomasLandauer Are you sure that the FQCN is necessary?

IMO the existing use statement should be sufficient.

Copy link
Member Author

@ThomasLandauer ThomasLandauer Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That use isn't copied over into the generated FunctionalTesterActions.php. And since that file doesn't have any uses at all, I figured the easiest way is to add the FQCN here. It's indeed ugly, but usually nobody looks into those Action files anyway...

* @param bool $append
* @throws ModuleException
* @throws ModuleRequireException
Expand Down
Loading