Skip to content

Fix loading incorrect values from config/app.php #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix loading incorrect values from config/app.php #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/Codeception/Lib/Connector/Laravel5.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,11 @@ private function initialize($request = null)

$this->app = $this->kernel = $this->loadApplication();

$this->app->make('Illuminate\Contracts\Http\Kernel')->bootstrap();

// Set the request instance for the application,
if (is_null($request)) {
$appConfig = require $this->module->config['project_dir'] . 'config/app.php';
$request = SymfonyRequest::create($appConfig['url']);
$request = SymfonyRequest::create($this->app['config']->get('app.url'));
}
$this->app->instance('request', Request::createFromBase($request));

Expand All @@ -208,8 +209,6 @@ private function initialize($request = null)
});
}

$this->app->make('Illuminate\Contracts\Http\Kernel')->bootstrap();

// Record all triggered events by adding a wildcard event listener
// Since Laravel 5.4 wildcard event handlers receive the event name as the first argument,
// but for earlier Laravel versions the firing() method of the event dispatcher should be used
Expand Down