-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with Codeception 5 and PHP 8.1 #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work!
Ok no problem. I will action all the above points shortly. |
Updated codeception version to alpha2 as required by this pull request Codeception/module-yii2#63
Changes made but blocked by other dependencies. Your requirements could not be resolved to an installable set of packages.
Will keep this open until the above can be satisfied. Cheers! |
I will fix remaining tests now I can get composer running on my local machine. |
With codeception/verify dropped back down to the original version, all tests now pass... |
I was confident that I released codeception/module-filesystem 3.0.0, but apparently I didn't. master branch was codeception 5 ready, we have to decide if we keep master branch or 3.0 branch. |
I think a v3.0 branch would be good to keep it consistent with the other repos. But ultimately it doesn’t matter right ? |
Master branch is more consistent. Most modules have master branch only, in some modules 1.x or 1.0 braches were created for applying patches to older versions. Getting rid of master branch would be a new thing. |
Maybe keep it in master branch and just tag the relevant release if it has breaking changes ? |
Codecept/verify 2.2 working and all tests pass. Hoping this can now be merged in once approved by everyone? |
👍 |
All tests pass.
Changes to yii2-advanced-template are required and are not breaking changes. So I will submit a PR to that repo shortly - this PR is here yiisoft/yii2-app-advanced#518
Once this and the above pull requests are accepted this module is good to go with Codecept V5 and PHP 8.1