Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Codeception 5 and PHP 8.1 #63

Merged
merged 21 commits into from
Feb 25, 2022
Merged

Compatibility with Codeception 5 and PHP 8.1 #63

merged 21 commits into from
Feb 25, 2022

Conversation

developedsoftware
Copy link

@developedsoftware developedsoftware commented Feb 23, 2022

All tests pass.

Changes to yii2-advanced-template are required and are not breaking changes. So I will submit a PR to that repo shortly - this PR is here yiisoft/yii2-app-advanced#518

Once this and the above pull requests are accepted this module is good to go with Codecept V5 and PHP 8.1

Screenshot 2022-02-23 at 16 59 59

Copy link
Member

@TavoNiievez TavoNiievez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

composer.json Outdated Show resolved Hide resolved
.gitignore Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@developedsoftware
Copy link
Author

Ok no problem. I will action all the above points shortly.

developedsoftware added a commit to developedsoftware/module-filesystem that referenced this pull request Feb 23, 2022
Updated codeception version to alpha2 as required by this pull request Codeception/module-yii2#63
@developedsoftware
Copy link
Author

Changes made but blocked by other dependencies.

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires codeception/module-filesystem ^3.0 -> satisfiable by codeception/module-filesystem[3.0.x-dev].
    - codeception/module-filesystem 3.0.x-dev requires codeception/codeception dev-5.0-interfaces as 5.0.0 -> found codeception/codeception[dev-5.0-interfaces] but it conflicts with your root composer.json require (^5.0.0-alpha2).
  Problem 2
    - Root composer.json requires codeception/codeception ^5.0.0-alpha2 -> satisfiable by codeception/codeception[5.0.0-alpha2, 5.0.x-dev].
    - codeception/verify dev-master requires phpunit/phpunit ^9.3 -> satisfiable by phpunit/phpunit[9.3.0, ..., 9.5.x-dev].
    - You can only install one version of a package, so only one of these can be installed: phpunit/phpunit[dev-master, 7.5.0, ..., 7.5.20, 8.0.0, ..., 8.5.x-dev, 9.0.0, ..., 9.5.x-dev].
    - codeception/codeception[5.0.0-alpha2, ..., 5.0.x-dev] require phpunit/phpunit dev-master as 9.5.99 -> satisfiable by phpunit/phpunit[dev-master].
    - Root composer.json requires codeception/verify dev-master -> satisfiable by codeception/verify[dev-master].

Will keep this open until the above can be satisfied. Cheers!

tests/bootstrap.php Outdated Show resolved Hide resolved
@TavoNiievez TavoNiievez changed the title Comptability with Codecept V5 and PHP 8.1 Compatibility with Codeception 5 and PHP 8.1 Feb 23, 2022
@developedsoftware
Copy link
Author

I will fix remaining tests now I can get composer running on my local machine.

@developedsoftware
Copy link
Author

With codeception/verify dropped back down to the original version, all tests now pass...

@Naktibalda
Copy link
Member

I was confident that I released codeception/module-filesystem 3.0.0, but apparently I didn't.

master branch was codeception 5 ready, we have to decide if we keep master branch or 3.0 branch.

@developedsoftware
Copy link
Author

I think a v3.0 branch would be good to keep it consistent with the other repos. But ultimately it doesn’t matter right ?

@Naktibalda
Copy link
Member

Master branch is more consistent.

Most modules have master branch only, in some modules 1.x or 1.0 braches were created for applying patches to older versions.

Getting rid of master branch would be a new thing.

@developedsoftware
Copy link
Author

Maybe keep it in master branch and just tag the relevant release if it has breaking changes ?

@developedsoftware
Copy link
Author

Codecept/verify 2.2 working and all tests pass. Hoping this can now be merged in once approved by everyone?

@samdark samdark merged commit 737e86a into Codeception:codecept5 Feb 25, 2022
@samdark
Copy link
Member

samdark commented Feb 25, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants