Upgrade to caddy v2 #112
Closed
Upgrade to caddy v2 #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since dependencies are old would be nice to use a tool like pip-compile to get a full list of dependencies before installation to save future headaches
|
@suvash Hey, thanks for working on this issue. Is it possible if you could re-submit the PR with the latest master/dev build. |
|
@pratimakandel Ah, I made this PR a long time ago. I don't remember the details in my head anymore. Please feel free to use any interesting parts from it. I'll close it in the meantime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took the time to dig into docs for Caddy v2 and it was simple enough.
However,
masterseems to be broken formake startfrom scratch. Took me a while to lock certain versions and get it rolling further, but I still see a lot of warnings in the db import logs.Also, since the dependencies used by this application is not very clear, I'd recommend using tool like
pip-compileto create a full dependency list and freeze it in requirements.txt, esp. given most of the packages use are getting old and new ones get installed by default.One more thing, I'm not sure of the migration path on keeping the same old certs, because options have changed in caddy on how/where it stores those files.
You should be able to
make starton this branch, but I'm not sure what else could be broken.