Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick view image not coming from optimole #87

Closed
ineagu opened this issue Mar 26, 2019 · 4 comments
Closed

quick view image not coming from optimole #87

ineagu opened this issue Mar 26, 2019 · 4 comments
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@ineagu
Copy link
Contributor

ineagu commented Mar 26, 2019

@selul When you are here and trying quick view: https://demo.themeisle.com/shop-isle-pro/shop/, the images aren't loading through optimole, we probably need custom integration, but is a good example in case we can find something generic.

The plugin is : https://wordpress.org/plugins/yith-woocommerce-quick-view/ and is quite popular.
@selul
Copy link
Contributor

selul commented Mar 27, 2019

@ineagu it does come but only when you are not logged. Because that's an ajax request, I have added the replacement handler to ajax responses only when you are not logged in because those ajax requests might be used in the admin area and we don't want to replace images in there.

I can add for the quick view a more specific replacement which will target the logged in users for the yith ajax request.

@selul
Copy link
Contributor

selul commented Mar 27, 2019

i have added a fix and patched the demo site too

@ineagu
Copy link
Contributor Author

ineagu commented Mar 27, 2019 via email

@selul selul closed this as completed in 60169b2 Mar 29, 2019
selul pushed a commit that referenced this issue Mar 29, 2019
@semantic-release-bot
chore(release): 2.0.6 [skip ci]
20dba2f 
#### [Version 2.0.6](v2.0.5...v2.0.6) (2019-03-29)

* **Bug Fixes**
   * adds compatibility with background images lazyload on Essential Grid plugin ([a73d1cd](a73d1cd))
   * compatibility with Oxygen builder, removes image replacement in the editor ([015698d](015698d))
   * compatibility with Woocommerce zoom image feature on product single pages ([4445d1e](4445d1e))
   * compatibility with YITH WooCommerce Quick View plugin, replacing images returned by the ajax request, fix [#87](#87) ([60169b2](60169b2))
   * cropping behaviour being inconsistent with due to variable reset in image parsing loop ([2b14e7c](2b14e7c))
   * remove unnecessary variables in the rest request causing conflicts with redirection plugins ([68c04ee](68c04ee))
   * Woocommerce image archive ratio, preserving cropping with Optimole images, fixes [#85](#85) ([a3a8504](a3a8504))

* **Features**
   * adds refresh stats button, syncing user details with Optimole dashboard, fix [#83](#83) ([1461483](1461483))
@selul
Copy link
Contributor

selul commented Mar 29, 2019

🎉 This issue has been resolved in version 2.0.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@selul selul added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ineagu @selul