Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding selection highlight improvements #420

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Dec 19, 2024

Summary

  • Show the Select button on the card click.
  • Add a highlight effect on hover.

Will affect visual aspect of the product

NO

Screenshots

image

2025-01-08_16-01-50.mp4

Test instructions

  • Check if, on hover, the blue border is shown as a highlight.
  • Check if clicking the Select button appears.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/2910

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Dec 19, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel changed the title refactor: show Select on card selection, add highlight on hover Onboarding selection highlight improvements Dec 20, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Jan 8, 2025
@Soare-Robert-Daniel Soare-Robert-Daniel marked this pull request as ready for review January 8, 2025 13:35
@pirate-bot
Copy link
Collaborator

pirate-bot commented Jan 8, 2025

Plugin build for 10ce76d is ready 🛎️!

@ineagu
Copy link
Contributor

ineagu commented Jan 8, 2025

@Soare-Robert-Daniel my bad here with the specs.

you're doing well to highlight the whole item on hover.

But: the select should not appear at all, the icon of the cursor should change to hand, so no matter where you click on the item, the "select" action would be triggered.

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Jan 8, 2025
@Soare-Robert-Daniel
Copy link
Contributor Author

@ineagu I updated the PR. Thanks for the clarification 👌

@Soare-Robert-Daniel Soare-Robert-Daniel changed the base branch from development to feat/onboarding-revamp January 14, 2025 12:08
@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 9c4fa0f into feat/onboarding-revamp Jan 14, 2025
9 of 10 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the refactor/card-hovering branch January 14, 2025 12:09
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 1.2.18 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants