Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onboarding layout overflow and responsiveness #429

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

abaicus
Copy link
Collaborator

@abaicus abaicus commented Feb 3, 2025

Summary

  • Fixes issue with overflow in starter sites onboarding layout container;
  • Uses available media-queries system instead of inlining new ones

Will affect visual aspect of the product

YES

Test instructions

  • Test the onboarding on all devices. Layout should look ok;
  • On desktop, the container should be limited to 1400px;
  • There should be no horizontal scroll bar;

Check before Pull Request is ready:

Closes #428.

@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Feb 3, 2025
@pirate-bot
Copy link
Collaborator

pirate-bot commented Feb 3, 2025

Plugin build for 22a6781 is ready 🛎️!

@abaicus abaicus force-pushed the fix/onboarding-layout branch from 327d882 to 22a6781 Compare February 3, 2025 15:54
@rodica-andronache
Copy link
Contributor

tested and it's working well 👍

@abaicus abaicus merged commit fc16dd3 into development Feb 5, 2025
7 checks passed
@abaicus abaicus deleted the fix/onboarding-layout branch February 5, 2025 15:21
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 1.2.19 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants